Retries for unverified Publishers

[hollons]

Description

Current spec

• keep each a/c and tips separate; convert all a/c values to tips once creator-XX is verified
• when a new publisher is verified, notify once that a publisher is verified "We will send your contributions to newly verified creator-XX" - action OK and close
• Try sending every tip based on time sequence, FIFO
• if tips fail, keep them in pending log at the browser till successful
• if tips fail due to lack of funds, notify first time ONLY when users retry that "You have pending tips due to insufficient funds" - action " Add funds" and drives to add-funds and close
• (Re) try every day

Each of the notifications ONLY the first time; one time for every verified publisher and one time only for failed retries due to lack of funds.

Obsolete spec
Part-2 of the unverified spec
https://docs.google.com/document/d/1y9eTyvvRkRXIDnRuCJ7SDzhK53kUnjsmuK9ZsGxnDiM/edit?usp=sharing

[mandar-brave]

prioritizing the issue for immediate nightly builds
@NejcZdovc @davidtemkin @evq @jenn-rhim @alexwykoff

Issue:
Currently all unverified Publisher contributions are stuck on the browser edge. However, if any of those publishers sign up, the retries for such held contributions is not retried.

What needs to happen: Tips and A-C

• A-C unverified will be considered as tips
• Against an unverified publisher, create one large TIP summing up all pending transactions

Step-1

• Try sending the transaction if budget permits as a single tip
  Step-2
• If that does not work, use the budget to pay the tip to max
• if any tip is sent, the first time create a notification for the user "Your tip of "XX" BAT to unverified "creator YY" was sent (only for amount sent)
• Keep a table for pending tips
• Check every day if there is budget and repeat step-1
  Step-3
  If multiple publishers qualify on any day, the one with the earliest timestamp trumps

[NejcZdovc]

@mandar-brave some adjustments:

Against an unverified publisher, create one large TIP summing up all pending transactions
We will not merge them together as in almost all cases user will not have enough funds.

I wrote the whole thing how this could work, but at the end I got a lot of edge cases. I think we need to process every transaction separately so that things are simple. The only thing that I don't know what to do with is a notification

[mandar-brave]

Updated spec;

• keep each a/c and tips separate; convert all a/c values to tips once creator-XX is verified
• when a new publisher is verified, notify once that a publisher is verified "We will send your contributions to newly verified creator-XX" - action OK and close
• Try sending every tip based on time sequence, FIFO
• if tips fail, keep them in pending log at the browser till successful
• if tips fail due to lack of funds, notify first time ONLY when users retry that "You have pending tips due to insufficient funds" - action " Add funds" and drives to add-funds and close
• (Re) try every day

Each of the notifications ONLY the first time; one time for every verified publisher and one time only for failed retries due to lack of funds.

cc @NejcZdovc

[GeetaSarvadnya]

Verification passed on

Brave	0.67.108 Chromium: 75.0.3770.100 (Official Build) beta (64-bit)
Revision	cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS	Windows 10 OS Version 1803 (Build 17134.523)

• Verified the test plan from Adds retries for unverified publishers brave-core#2512 (Tested on staging env)
• Verified the Publisher is verified notification after clicking on Refresh Status

• Verified that Tips are processed after the publisher becomes verified and tips are removed from Pending Contribution list
• Verified the Insufficient funds notification, when wallet balance is less than the Tip amount
  
  
• Verified that the Auto Contribute, One-time Tip, Recurring Tip are removed from pending list when publisher becomes verified
• Encountered pending AC values are rounded once publisher verifies - follow up to 3741 #4886
• Verified that the auto contribute values and recurring tips were removed from the pending list and added to Tips panel as one-time tips once creator becomes verified.

Verification passed on

Brave	0.67.110 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision	cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS	Ubuntu 18.04 LTS

• Verified the test plan from Adds retries for unverified publishers brave-core#2512 (Tested on staging env)
• Verified the Publisher is verified notification after clicking on Refresh Status

• Verified that Tips are processed after the publisher becomes verified and tips are removed from Pending Contribution list

• Verified that the Auto Contribute, One-time Tip, Recurring Tip are removed from pending list when publisher becomes verified
• Verified that the auto contribute values and recurring tips were removed from the pending list and added to Tips panel as one-time tips once creator becomes verified.

Verified passed with

Brave	0.67.112 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision	7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS	Mac OS X

• Verified the test plan from Adds retries for unverified publishers brave-core#2512 (Tested on staging env)
• Verified that the auto contribute values and recurring & one time tips were removed from the pending list and added to Tips panel as one-time tips once creator becomes verified.
• Verified additional cases outlined in Adds retries for unverified publishers brave-core#2512 (comment)