Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One time tip shows incorrect message on banner #3481

Closed
GeetaSarvadnya opened this issue Feb 25, 2019 · 3 comments · Fixed by brave/brave-core#1789
Closed

One time tip shows incorrect message on banner #3481

GeetaSarvadnya opened this issue Feb 25, 2019 · 3 comments · Fixed by brave/brave-core#1789

Comments

@GeetaSarvadnya
Copy link

Description

One time tip shows incorrect message on banner

Steps to Reproduce

  1. Clean profile 0.61.36
  2. Open DDG
  3. Send one-time tips to DDG
  4. Verify banner message after tipping - message displayed as expected
  5. Send monthly tips to DDG
  6. Verify banner message after tipping - message displayed as expected
  7. Send one-time tips to DDG
  8. Verify banner message - shows up monthly tip message which is not correct.

Actual result:

One time tip shows incorrect message on banner

Expected result:

One-time tips message should be displayed instead of monthly

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.61.36 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 10 OS Build 17134.523

Reproducible on current release: NO

  • Does it reproduce on brave-browser dev/beta builds? yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? na
  • Is the issue reproducible on the latest version of Chrome? na

Additional Information

@brave/legacy_qa

@GeetaSarvadnya GeetaSarvadnya added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 25, 2019
@btlechowski
Copy link

Reproduced on

Brave 0.61.37 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 7 Service Pack 1 Build 7601.24312

@kjozwiak
Copy link
Member

Reproducible on macOS 10.14.3 x64 using the following build:

Brave 0.61.38 Chromium: 73.0.3683.39 (Official Build) beta(64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Mac OS X

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Mar 7, 2019

Verification passed on

rave 0.61.48 Chromium: 73.0.3683.56 (Official Build) beta (64-bit)
Revision 303af44e2f2948869279f120021c778855d76ead-refs/branch-heads/3683@{#653}
OS Windows 10 OS Build 17134.523

Verified passed with

Brave 0.61.48 Chromium: 73.0.3683.56 (Official Build) beta(64-bit)
Revision 303af44e2f2948869279f120021c778855d76ead-refs/branch-heads/3683@{#653}
OS Mac OS X

Verification passed on

Brave 0.61.49 Chromium: 73.0.3683.67 (Official Build) (64-bit)
Revision a83fd4f3207ae83412d329a9ca1239dd1e068345-refs/branch-heads/3683@{#760}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants