Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add detailed view of pending contributions #3175

Closed
NejcZdovc opened this issue Jan 31, 2019 · 1 comment · Fixed by brave/brave-core#1528
Closed

Add detailed view of pending contributions #3175

NejcZdovc opened this issue Jan 31, 2019 · 1 comment · Fixed by brave/brave-core#1528
Assignees
@NejcZdovc
Labels
feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
0.67.x - Release

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jan 31, 2019 •
edited by bsclifton
Loading

Test plan

See brave/brave-core#1528

Description

Add detailed view (like we have see all for AC) for pending contribution. Also add manual removal for contribution
@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Jan 31, 2019
@NejcZdovc NejcZdovc self-assigned this Jan 31, 2019
@NejcZdovc NejcZdovc mentioned this issue Jan 31, 2019
Merged
18 tasks
NejcZdovc added a commit to brave/brave-core that referenced this issue Feb 5, 2019
@NejcZdovc
Adds detailed view for pending contributions
f954136 
Resolves brave/brave-browser#3175
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Mar 8, 2019
@NejcZdovc
Adds detailed view for pending contributions
092bf01 
Resolves brave/brave-browser#3175
@ryanml ryanml self-assigned this Apr 3, 2019
@NejcZdovc NejcZdovc removed their assignment Apr 4, 2019
@NejcZdovc NejcZdovc assigned NejcZdovc and unassigned ryanml Apr 19, 2019
@NejcZdovc NejcZdovc added this to the 0.67.x - Nightly milestone May 15, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue May 17, 2019
@NejcZdovc
Adds detailed view for pending contributions
1ad9a93 
Resolves brave/brave-browser#3175
NejcZdovc added a commit to brave/brave-core that referenced this issue May 20, 2019
@NejcZdovc
Adds detailed view for pending contributions
6870c7c 
Resolves brave/brave-browser#3175
NejcZdovc added a commit to brave/brave-core that referenced this issue May 24, 2019
@NejcZdovc
Adds detailed view for pending contributions
389c175 
Resolves brave/brave-browser#3175
NejcZdovc added a commit to brave/brave-core that referenced this issue May 27, 2019
@NejcZdovc
Adds detailed view for pending contributions
3ffeb6f 
Resolves brave/brave-browser#3175
@LaurenWags
Copy link
Member

LaurenWags commented Jul 10, 2019 •
edited by btlechowski
Loading

Verified passed with

Brave 0.67.106 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Mac OS X
  • Verified test plan from Adds detailed view for pending contributions brave-core#1528
  • Verified AC, recurring tips, and one time tips are added to the table and displayed.
  • Verified for regular sites, YT channels, Twitch, and Twitter.
  • Verified when a site/channel was removed from the list, the sum/total of pending contributions displayed on brave://rewards and from panel was updated accordingly.
    Screen Shot 2019-07-10 at 9 44 34 AM
    Screen Shot 2019-07-10 at 9 45 07 AM

Verification passed on

Brave 0.67.106 Chromium: 75.0.3770.100 (Official Build) beta (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified AC, recurring tips, and one time tips are added to the table and displayed.
  • Verified for regular sites, YT channels, Twitch, and Twitter.
  • Verified when a site/channel was removed from the list, the sum/total of pending contributions displayed on brave://rewards and from panel was updated accordingly.

image

Verification passed on

Brave 0.67.110 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Ubuntu 18.04 LTS
  • Verified AC, recurring tips, and one time tips are added to the table and displayed.
  • Verified for regular sites, YT channels, Twitch, and Twitter.
  • Verified when a site/channel was removed from the list, the sum/total of pending contributions displayed on brave://rewards and from panel was updated accordingly.

image

@LaurenWags LaurenWags mentioned this issue Jul 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
0.67.x - Release
Development

Successfully merging a pull request may close this issue.

Adds detailed view for pending contributions brave/brave-core
7 participants
@bsclifton @rebron @ryanml @NejcZdovc @LaurenWags @btlechowski @GeetaSarvadnya