-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix users in a bad state due to 2962 #3046
Comments
Thank you for providing all of the technical lingo & info for us laymen. It's greatly appreciated. |
See also: #2649 |
@liunkae - do you happen to know what the panel (when you click on BAT logo) shows when you're in this 'unable to create wallet' state from 2649? |
@LaurenWags I'll get a screenshot once I get back to my computer in a few hours. |
awesome, thanks @liunkae ! |
Is there a value we can delete in a config file or some other location in the installed folder? |
@LaurenWags Here is what the panel shows when I launch Brave: |
@dontezuma Until the underlying problem is found, the only way to fix this is to completely reset the browser profile. On macOS (it's different for each platform), you have to rename/delete |
The goal, of course, is to have one wallet associated with whatever device I'm using Brave on. I'm using Sync as a beta, and would hope that I could set up my wallet address on any instance of Brave associated with me. |
Thanks for grabbing that screenshot @liunkae - sounds exactly like a scenario I hope this issue will resolve. |
@LaurenWags can you please add broken profile to this issue. Please point it to staging. Thank you |
@NejcZdovc I couldn't reproduce on macOS, so here's a Windows profile |
Verification passed on
Used staging profile provided by @LaurenWags : #3046 (comment) If I go to I can still see the Verified passed with
Verification passed on
|
Description
Follow up to #2962
Due to 2962 some users got into a bad state where they are unable to join Brave Rewards. We should fix users in this bad state so they can join Brave Rewards.
Additionally, some users reported unable to join Brave Rewards with #2997 - I am unsure if this is the same root cause, but it would be nice to fix for them as well.
Steps to Reproduce
Steps copied from #2962
You'll reproduce 100% when you don't see the initial notification appear within the Rewards panel.
Note - was able to get into this bad state on 0.60.13 Dev and 0.59.25 Beta per comments on that issue.
Actual result:
Clicking on the BAT logo opts you into rewards, but your ledger_state file is missing values so you don't have a real wallet. Additionally, you may or may not see a wallet creation failed error on brave://rewards page when trying to opt in after getting into this bad state.
Expected result:
This issue should fix anyone currently in a bad state.
Reproduces how often:
easily
Brave version (brave://version info)
0.60.13 Dev or 0.59.25 Beta
Reproducible on current release:
Website problems only:
Additional Information
cc @NejcZdovc @kjozwiak
The text was updated successfully, but these errors were encountered: