Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebTorrent should be responsive #3034

Closed
rossmoody opened this issue Jan 21, 2019 · 4 comments
Closed

WebTorrent should be responsive #3034

rossmoody opened this issue Jan 21, 2019 · 4 comments

Comments

@rossmoody
Copy link
Contributor

rossmoody commented Jan 21, 2019

Test plan

See brave/brave-core#1406

Description

The WebTorrent view has a tendency to break and/or format poorly if sized down. Could use some responsive designations and a few polish tweaks to the copy. Should also likely surface copy for the ability to disable this feature in settings until a proper product/design spec can be made and put on the roadmap to address a cohesive experience with this feature.

screen shot 2019-01-21 at 11 30 40 am

@rossmoody rossmoody added the feature/webtorrent Label for webtorrent related issues label Jan 21, 2019
@rossmoody rossmoody self-assigned this Jan 21, 2019
@rebron rebron added this to the 1.x Backlog milestone Jan 22, 2019
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Jan 22, 2019
@bsclifton bsclifton modified the milestones: 1.x Backlog, 0.62.x - Nightly Jan 25, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Feb 11, 2019

@rossmoody the 'Privacy Warning' in 0.60.23 doesn't exactly match the text on the screenshots in the PR (https://user-images.githubusercontent.com/29072694/51495473-579e1a80-1d71-11e9-83e9-b61fc2b3b62c.png) . Here's what's in 0.60.23:
screen shot 2019-02-11 at 5 03 20 pm

Can you confirm if this Privacy Warning is what is expected?

Also - test plan itself looks good - page appears responsive. Logged #3315 for what looks like a text mistake. Just want to confirm that the Privacy Warning text is ok as is. If not, I can log a new issue for it to be updated.

@rossmoody
Copy link
Contributor Author

@LaurenWags good spot. this text is intended except for that one typo. will fix today.

@LaurenWags
Copy link
Member

thanks @rossmoody 😄

@LaurenWags
Copy link
Member

LaurenWags commented Feb 11, 2019

Verified passed with

Brave 0.60.26 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Mac OS X

Verification passed on

Brave 0.60.27 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Windows 10

image

image

image

Verification passed on

Brave 0.60.26 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Linux

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants