Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap quotes continue to fetch even when an order is in review/submitted/executed #28063

Closed
srirambv opened this issue Jan 26, 2023 · 2 comments · Fixed by brave/swap#124 or brave/brave-core#17239
Assignees
Labels
bug feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

Description

Swap quotes continue to fetch even when an order is in review/submitted/executed

Steps to Reproduce

  1. Initiate a Swap transaction
  2. Click on review order so panel opens up to review before submitting
  3. Keep panel open
  4. Swap keeps fetching quote irrespective of order being submitted or not

Actual result:

image
image

Expected result:

Clear out the fields when an order review is submitted

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.49.59 Chromium: 110.0.5481.40 (Official Build) nightly (64-bit)
Revision 371638c3173bebbbb05361ed503673a3aba42e61-refs/branch-heads/5481@{#395}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @onyb @jamesmudgett @minkyeongshin

@kjozwiak
Copy link
Member

The above requires 1.48.166 or higher for 1.48.x verification 👍

@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.48.166 Chromium: 110.0.5481.100 (Official Build) (64-bit)
Revision 4be7a36f7cb943af6118e449bbab494b43dcaddd-refs/branch-heads/5481_77@{#14}
OS Windows 11 Version 22H2 (Build 22621.1265)
  • Verified steps from issue description
  • Verified quotes are reset when review order is clicked and panel opens up
  • Verified amount is reset when user changes the Swap From token
28063.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
6 participants