Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option in Settings to install/enable and uninstall/disable Widevine Plugin (Muon parity) #2791

Closed
Brave-Matt opened this issue Jan 2, 2019 · 16 comments · Fixed by brave/brave-core#7554
Assignees
Labels
browser-laptop-parity design A design change, especially one which needs input from the design team feature/global-settings Settings at browser level independent of shields settings feature-request OS/Desktop plugin/Widevine priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@Brave-Matt
Copy link

Description

We have an open issue to make the "install/run widevine" prompt more obvious to the user and to display on all sites that require it (rather than having to navigate to Netflix or Hulu to do so). I have seen several users, however, ask if there is a way for the to uninstall Widevine on their machine.

Currently, there's no way to uninstall Widevine without uninstalling Brave entirely. In Brave Muon, there was a switch in Preferences --> Plugins --> Widevine that allowed this functionality. It would be useful to make this accessible to Core builds as well.
image

Additional Information

One user here from Reddit asking how to disable Widevine - will continue to add reports to this thread as I see them:
https://www.reddit.com/r/brave_browser/comments/abp4vq/how_to_disable_widevine/

@kjozwiak kjozwiak added this to the 1.x Backlog milestone Jan 2, 2019
@srirambv
Copy link
Contributor

srirambv commented Jan 3, 2019

Check media license in clear data modal under advance. This removes any media related settings that is set on the active profile. It will prompt again to install and run when you visit the site again. This avoids the uninstall/reinstall component problem. This is the safest way to ensure the component is installed but only works after you explicitly make it run.

@rebron rebron added browser-laptop-parity priority/P3 The next thing for us to work on. It'll ride the trains. labels Jan 4, 2019
@Brave-Matt
Copy link
Author

@srirambv, I have a few users saying that this doesn't always fix the issue. The option is also buried fairly deep in content settings. I think components like this should be surfaced as much as possible.

@rebron rebron added the feature/global-settings Settings at browser level independent of shields settings label Jan 8, 2019
@rebron rebron added the design A design change, especially one which needs input from the design team label Jan 8, 2019
@rebron
Copy link
Collaborator

rebron commented Jan 8, 2019

Should go in the same area where we display WebTorrent pref.

@tamj0rd2
Copy link

tamj0rd2 commented Feb 3, 2019

It would be really helpful to have an option to just install or uninstall it through the settings menu. I'm running into an issue where the install prompt isn't coming up on Netflix. It worked fine when I tried on Windows but isn't working at all on ubuntu using the normal release or Dev.

@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@johnsen32
Copy link

johnsen32 commented Mar 3, 2019

In case anyone else comes across this issue and is still wondering how the heck one can get netflix to work with Brave, here is the solution:

Put shields down. Refresh. Check top right corner for pop-up icon. Right besides Brave rewards. Accpet widewine install. Watch netflix. Keep shields down.

Source:
https://www.reddit.com/r/BATProject/comments/a9uqk4/widevine_install_problems_for_brave_browser/

This should not be that hard, took me almost an hour to find the solution.
Please improve usability for such cases.

@bsclifton
Copy link
Member

bsclifton commented Mar 4, 2019

@johnsen32 thanks for the feedback 😄Definitely important for us to solve this issue

In the meantime, we do have a more obvious notification (fixed in master). This will be making its way through the channels (dev, beta, release). Check out a preview of how it looks here:
#1940 (comment)

@simonhong simonhong self-assigned this Mar 13, 2019
@Brave-Matt
Copy link
Author

+1 from Reddit:
https://www.reddit.com/r/brave_browser/comments/abp4vq/how_to_disable_widevine/ekcnl66?utm_source=share&utm_medium=web2x

@Brave-Matt
Copy link
Author

+2 from Community:
https://community.brave.com/t/remove-drm-from-brave/54081

@rebron
Copy link
Collaborator

rebron commented Apr 17, 2019

@tamj0rd2 can you try Netflix/Widevine again on Ubuntu in current release or any channel you prefer (beta/dev/nightly). We have widevine working now as of 62.x.

@deoxal
Copy link

deoxal commented Apr 18, 2019

Should go in the same area where we display WebTorrent pref.

Would it be possible to use it on a per site basis like with camera, microphone, camera etc?

@Brave-Matt
Copy link
Author

+1 from reddt:
https://www.reddit.com/r/brave_browser/comments/c86e03/would_like_a_flag_or_setting_to_gloablly_disable/

@Brave-Matt
Copy link
Author

+1 from Community:
https://community.brave.com/t/how-to-completelly-remove-widevine-from-brave-ubuntu/73658

@Brave-Matt Brave-Matt reopened this Apr 29, 2020
@simonhong simonhong self-assigned this Jan 11, 2021
simonhong added a commit to brave/brave-core that referenced this issue Jan 11, 2021
This toggle option register/unregister widevine cdm components.

Resolves brave/brave-browser#2791
simonhong added a commit to brave/brave-core that referenced this issue Jan 11, 2021
This toggle option register/unregister widevine cdm components.

Resolves brave/brave-browser#2791
simonhong added a commit to brave/brave-core that referenced this issue Jan 15, 2021
This toggle option register/unregister widevine cdm components.

Resolves brave/brave-browser#2791
simonhong added a commit to brave/brave-core that referenced this issue Jan 19, 2021
This toggle option register/unregister widevine cdm components.

Resolves brave/brave-browser#2791
@simonhong simonhong added this to the 1.21.x - Nightly milestone Jan 20, 2021
@stephendonner
Copy link

stephendonner commented Feb 8, 2021

Verified with testplan from brave/brave-core#7554 on

Brave 1.21.44 Chromium: 88.0.4324.146 (Official Build) beta (x86_64)
Revision 406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088}
OS macOS Version 11.2 (Build 20D64)
Case 1:
  • go to Settings -> Extensions
  • confirm default value "Enable Widevine" is disabled
  • log in to hulu, hbomax, or netflix; play media
  • confirm install of Widevine, when prompted
  • verify playing media works
  • return to Settings and confirm that Enable Widevine is now checked

image

Case 2:
  • go to Settings -> Extensions
  • confirm default value "Enable Widevine" is disabled
  • toggle "Enable Widevine" to on
  • confirm you get "Your changes will take effect the next time you relaunch Brave." text at bottom, with "Relaunch Now" button
  • click Relaunch Now
  • after relaunch, return to Settings and confirm that Enable Widevine is now checked
  • open brave://components, confirm that **Widevine Content Decryption Module** appears, with "Status - Up-to-date"
  • log in to hulu, hbomax, or netflix; play media
  • verify you are NOT prompted to install Widevine, and playing media works

image

Case 3:
  • go to Settings -> Extensions
  • confirm default value "Enable Widevine" is disabled
  • log in to hulu, hbomax, or netflix; play media
  • confirm install of Widevine, when prompted
  • verify playing media works
  • return to Settings and confirm that Enable Widevine is now toggled on
  • uncheck "Enable Widevine" and click Relaunch now
  • upon relaunch, verify that Widevine doesn't appear in brave://components/
    image

image


Verification passed on

Brave 1.21.52 Chromium: 88.0.4324.152 (Official Build) dev (64-bit)
Revision 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#7554

Verified after enabling widevine through brave://settings/extensions, the prompt is shown to relaunch the browser:
image
Verified after browser is relaunched, the widevine is listed in brave://components
image
Verified able to play the media from hbomax, netflix.
Verified able to disable widevine
image
Verified prompt is shown on netflix when widevine is disabled
image

Logged #14144
Logged #14146


Verification passed on


Brave | 1.21.63 Chromium: 88.0.4324.182 (Official Build) dev (64-bit)
-- | --
Revision | 73ee5087001dcef33047c4ed650471b225dd8caf-refs/branch-heads/4324@{#2202}
OS | Windows 10 OS Version 2004 (Build 19041.804)


Verified the test plan from brave/brave-core#7554

Verified after enabling widevine through brave://settings/extensions, the prompt is shown to relaunch the browser:
image

Verified after the browser is relaunched, the widevine is listed in brave://components
image
Verified able to play the media from hbomax, netflix.
Verified able to disable widevine
image
Verified that widevine component is removed from brave://components when widevine is disabled from brave://settings/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-laptop-parity design A design change, especially one which needs input from the design team feature/global-settings Settings at browser level independent of shields settings feature-request OS/Desktop plugin/Widevine priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.