Remove icon fetching for unverified media publishers

[mandar-brave]

Test Plan

• Removes icon fetching for unverified publishers brave-core#1200

Original Issue Filed

Remove icon scraping for media publishers if they are not verified.

cc @NejcZdovc @diracdeltas

[diracdeltas]

for regular sites, the icon is from chromium icon db, not scraping, so those can be unchanged

…

On Sun, Dec 23, 2018 at 12:59 mandar-brave ***@***.***> wrote: Remove icon scraping for any sites or channel from BR code. cc @NejcZdovc <https://github.com/NejcZdovc> @diracdeltas <https://github.com/diracdeltas> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2717>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAhjFmfx4K3f8JjWrZ-rEonRfH0ds5fgks5u78SdgaJpZM4Zf70S> .

[btlechowski]

Verification passed on

Brave	0.58.20 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision	15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS	Windows 7

Used test plan from brave/brave-core#1200
All PASSED
Verified page: https://kjozwiak.github.io/
Unverified page: https://www.interia.pl/
Verified youtube: https://www.youtube.com/watch?v=GNszD3W_G_g
Unverified youtube: https://www.youtube.com/watch?v=ZNjdf0F695Y

Verification passed on

Brave	0.58.20 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision	15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS	Linux

Verified passed with

Brave	0.58.20 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision	15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS	Mac OS X

• Verified test plan from Removes icon fetching for unverified publishers brave-core#1200
• Verified icons for verified sites display in a-c table, tips table, and panel
• Verified icons for unverified sites display in a-c table, tips table, and panel
• Verified icons for verified YT channels display in a-c table, tips table, and panel
• Verified icons for unverified YT channels do not display in a-c table, tips table, or panel (note - one time tips to unverified publishers do not display in tips table per discussion with @NejcZdovc . I used recurring tips to illustrate the icon does not display.)
  
  

Also verified icons for Twitch publishers in a-c table only (no tips table or panel since tipping is not implemented for Twitch yet):