Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 106 to Chromium 107 #25658

Closed
emerick opened this issue Sep 27, 2022 · 9 comments · Fixed by brave/brave-core#14969
Closed

Upgrade from Chromium 106 to Chromium 107 #25658

emerick opened this issue Sep 27, 2022 · 9 comments · Fixed by brave/brave-core#14969

Comments

@emerick
Copy link
Contributor

emerick commented Sep 27, 2022

Upgrade from Chromium 106 to Chromium 107.

https://chromium.googlesource.com/chromium/src/+log/106.0.5249.65..107.0.5304.36/?pretty=fuller&n=10000

QA tests:
This is a major Chromium version bump, please do full passes.

Desktop Affected areas:

  • Extensive internal changes to brave://settings (everything needs testing here, including toolbar)
  • Content settings
  • Side panel
  • Minor Linux-related changes to system theme
  • Linux-related changes to Vulkan, enabled via Finch
  • Verify that file system access flag is still working as expected
  • Verify that vertical tabs experiment continues to work as expected

Android Affected areas:

  • NTP layout
  • Sync (double check it generally works)
  • Autocomplete and suggestions
  • Background video playback

When uplifting, also uplift:

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 17, 2022

Verification PASSED on


Brave | 1.46.63 Chromium: 107.0.5304.36 (Official Build) nightly (64-bit)
-- | --
Revision | 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS | Windows 10 Version 21H2 (Build 19044.2130)

Issues logged

Extensive internal changes to brave://settings_PASSED

Testing is covered in Settings comparison section below

Content settings_PASSED
  • Confirmed that Shields settings is been added in brave://settings/content (more info: Add Brave's Shields setting to brave://settings/content #12782)
  • Added few sites to shields up and shields down list and ensured sites got added to shield settings list
  • Open the sites (which are added in shield down list) in PT/TOR tab windows and ensured shields are down as expected
Example Example
image image
Side panel_PASSED
  • Confirmed that sidebar is shown by default in the nightly channel
  • Confirmed that Reading list icon is added to the sidebar menu
  • Confirmed that reading list panel is shown when user click on the Reading list icon in the sidebar menu
  • Confirmed that user can add the list of websites to the reading list by clicking on the +Add current tab
  • Confirmed that user can add the list of websites to the reading list by right clicking on the tab and choose the option Add tab to the reading list
  • Confirmed that reading list panel can be hidden by clicking on the Reading list icon in the sidebar menu
  • Confirmed that reading list icon is shown in the URL bar, next to wallet icon
  • Confirmed that user can enable/disable the reading list by clicking on the reading list icon (shown in the URL bar)
  • Confirmed that reading list is shown in all the window types (Normal, PT, TOR and Guest window)
  • Websites can't be added to reading list in Guest, encountered Unable to add a site to reading list in Guest window as Add to current tab option is not getting activated #24930
  • Confirmed that sites can be segregated to Read and Unread list
  • Confirmed that sites can be deleted from the reading list
Example Example Example Example
image image image image
Verify that file system access flag is still working as expected_PASSED
Verify that vertical tabs experiment continues to work as expected_PASSED
  • Confirmed that vertical tabs get enabled when the flag #brave-vertical-tabs is enabled via brave://flags
  • Verified that sites can be added to vertical tab by clicking on the +
  • Right click on any site added in the vertical tab shown tab context menu options
  • Verified that reading list and vertical tabs cab be enabled at the same time
  • Right click on any site and select New tab to the right context menu option and ensured new tab got added to the right
  • Right click on any site and select Add tab to reading list context menu option and ensured site can be added to the reading list
  • Right click on any site and select Add a tab to new group and ensured that the selected site can be added to new tab group
  • Right click on the sites in vertical tab and select Add a tab to new group and then created tab (e.g test which I have created in my testing) group and ensured that sites got added to the tab group test
  • Verified that created tab group can be collapsed/expanded, when the group is expanded sites added in tab groups are shown
  • Right click on any site in vertical tab and select Move tab to another window and ensured that tab is opened in an new window
  • When a tab is moved to the new window, if user try to move another tab to new window, user get option to move the tab to the existing (2nd window) or new window, ensured both options works fine
  • Right click on any site in vertical tab and select Reload context menu option and ensured site gets reloaded/refreshed
  • Right click on any site in vertical tab and select Duplicate context menu option and ensured duplicate tab got added to the tab group
  • Right click on any site in vertical tab and select Pin context menu option and ensured site pinned in the tab group and right clicked on the pinned tab and ensured Unpin option is shown
  • Ensured that pinned site can be unpinned by clicking on the Unpin option
  • Right click on any YT site in vertical tab and select mute context menu option and ensured site is muted and mute option is shown in the URL bar and video is playing in an muted mode.
  • Ensured that YT videos can be unmuted by clicking on the Unmute option
  • Ensured that Close, Close other tabs, Close tabs to the right and Reopen closed tabs works as expected
  • Ensured that the tab Bookmarls all context menu works as expected
  • Ensured that tabs can be drag and drop in an vertical tab
  • Ensured that vertical tab cab be collapsed/expanded, when vertical tabs is expand the tabs with site name and url is shown, when vertical tab cab be collapsed, the site favicons are shown in the vertical tabs
Example Example Example Example Example Example Example Example Example Example Example Example Example Example
image image image image image image image image image image image image image image
----------------

Settings comparison

Example Example
image image

image (3)

image

  • Confirmed that the link Import passwords and the text Create, save, and manage your passwords so you can easily sign in to sites and apps is been added in the brave://settings/passwords page as part of CR 107
    image
  • Confirmed that the link Import passwords works as expected
  • Confirmed that Shields settings in been added in brave://settings/content (more info: Add Brave's Shields setting to brave://settings/content #12782)
  • Added few sites to shields up and shields down list and ensured sites got added to shield settings list
Example Example
image image

Components updater

  • No new components are added as part of CR 107
  • Components are updates successfully without any error
  • New component Brave Ad Block Resources Library is been added as part of brave

image

1.46.64 Chromium: 107.0.5304.36 1.44.64 Chromium: 106.0.5249.119
image image

Brave startup calls

  • Confirmed that only brave domains are listed in the Charles when the nightly build is launched with a clean profile
  • Confirmed no calls to google, gstatic, etc domains when the nightly build is launched with a clean profile

@kjozwiak
Copy link
Member

Discussed the Vulkan portion with @SergeyZhukovsky and @GeetaSarvadnya regarding the Linux-related changes to Vulkan, enabled via Finch item listed above. While running through Vulkan on Android, @SergeyZhukovsky noticed that Google will begin enabling/disabling certain flags starting at 10% as per the following:

  {
    "name": "Vulkan",
    "consistency": "PERMANENT",
    "experiment": [
      {
        "name": "Enabled_107.0.5304.15",
        "probabilityWeight": 10,
        "featureAssociation": {
          "enableFeature": [
            "DefaultANGLEVulkan",
            "Vulkan",
            "VulkanFromANGLE"
          ]
        }
      },
      {
        "name": "Control_107.0.5304.15",
        "probabilityWeight": 10,
        "featureAssociation": {
          "disableFeature": [
            "DefaultANGLEVulkan",
            "Vulkan",
            "VulkanFromANGLE"
          ]
        }
      },
      {
        "name": "Default",
        "probabilityWeight": 80
      },
      {
        "name": "_Activation",
        "probabilityWeight": 0,
        "featureAssociation": {
          "disableFeature": [
            "DefaultANGLEVulkan",
            "Vulkan",
            "VulkanFromANGLE"
          ]
        }
      },
      {
        "name": "ForcedOn_DefaultANGLEVulkan",
        "probabilityWeight": 0,
        "featureAssociation": {
          "forcingFeatureOn": "DefaultANGLEVulkan"
        }
      },
      {
        "name": "ForcedOff_DefaultANGLEVulkan",
        "probabilityWeight": 0,
        "featureAssociation": {
          "forcingFeatureOff": "DefaultANGLEVulkan"
        }
      },
      {
        "name": "ForcedOn_Vulkan",
        "probabilityWeight": 0,
        "featureAssociation": {
          "forcingFeatureOn": "Vulkan"
        }
      },
      {
        "name": "ForcedOff_Vulkan",
        "probabilityWeight": 0,
        "featureAssociation": {
          "forcingFeatureOff": "Vulkan"
        }
      },
      {
        "name": "ForcedOn_VulkanFromANGLE",
        "probabilityWeight": 0,
        "featureAssociation": {
          "forcingFeatureOn": "VulkanFromANGLE"
        }
      },
      {
        "name": "ForcedOff_VulkanFromANGLE",
        "probabilityWeight": 0,
        "featureAssociation": {
          "forcingFeatureOff": "VulkanFromANGLE"
        }
      }
    ],
    "filter": {
      "minVersion": "107.0.5304.15",
      "channel": [
        "STABLE"
      ],
      "platform": [
        "PLATFORM_LINUX"
      ],
      "endDate": "1669852800",
      "minOsVersion": "5.10.0"
    },
    "randomizationSeed": 1180992569
  }

However, 90% of the users will stay in the Default cohort. Because this seems like an experiment, there's nothing we need to do on our side other than keep an eye on their study. Once they start enabling the flags on most of the population, we'll need to take a look and do the same via Griffin. However, for the C107 release, there's nothing to do in terms of QA verification/checks before signing off.

@btlechowski
Copy link

Verification passed on

Brave 1.46.54 Chromium: 107.0.5304.36 (Official Build) nightly (64-bit)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS Ubuntu 18.04 LTS

Verified Minor Linux-related changes to system theme

On Linux we force theme color based on channel: Release - Light, Beta - Light, Nightly - Dark, it does not have System theme

Dark

Verified for nightly, default theme is dark:
image
image
image
image

verified private window, guest window and private window with tor have proper theme colors:
image
image
image

Light

Verified light theme looks OK:
image
image

verified private window, guest window and private window with tor have proper theme colors:
image
image
image

@Uni-verse
Copy link
Contributor

Uni-verse commented Oct 18, 2022

Verified on Samsung Galaxy Tab S7 using

Brave	1.46.64 Chromium: 107.0.5304.36 (Official Build) canary (64-bit) 
Revision	2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS	Android 12; Build/SP1A.210812.016

NTP layout

  • Verified NTP elements
  • Verified disabling top sites will be reflected in NTP
  • Verified brave news feed is displayed
  • Verified content menus work on top sites, and items in the news feed
  • Verified user is able to disable background/background images from showing on NTP
Example Example Example
screenshot-1666117555099 screenshot-1666117573838 screenshot-1666117631947

Sync (double check it generally works)

  • Verified able to join sync chain
  • Verified able to start a sync chain and add other devices
  • Verified able to join using code words using sync chain
  • Verified send to device works
Example Example Example Example
screenshot-1666116910096 screenshot-1666116917356 screenshot-1666116932221 screenshot-1666116949744

Autocomplete and suggestions

  • Verified suggestions are shown in the url content box, tapping on the suggestion will auto populate in text fields.
  • Verified Autocompleting works in url box

0

Background video playback

  • Verified background video playback is off by default
  • Verified enabling background video playback will allow playback when app is backgrounded and when device screen is locked.

@Uni-verse
Copy link
Contributor

Uni-verse commented Oct 18, 2022

Verified on Samsung Galaxy S21 using

Brave	1.46.64 Chromium: 107.0.5304.36 (Official Build) canary (64-bit) 
Revision	2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS	Android 12; Build/SP1A.210812.016

NTP layout

  • Verified NTP elements
  • Verified disabling top sites will be reflected in NTP
  • Verified brave news feed is displayed
  • Verified content menus work on top sites, and items in the news feed
  • Verified user is able to disable background/background images from showing on NTP
Example Example
screenshot-1666119573696 screenshot-1666119673281

Sync (double check it generally works)

  • Verified able to join sync chain
  • Verified able to start a sync chain and add other devices
  • Verified able to join using code words using sync chain
  • Verified send to device works
Example Example Example
screenshot-1666119708589 screenshot-1666119716797 screenshot-1666119883464

Autocomplete and suggestions

  • Verified suggestions are shown in the url content box, tapping on the suggestion will auto populate in text fields.
  • Verified Autocompleting works in url box
Example Example
screenshot-1666119637686 screenshot-1666119652412

Background video playback

  • Verified background video playback is off by default
  • Verified enabling background video playback will allow playback when app is backgrounded and when device screen is locked.

@kjozwiak
Copy link
Member

The above requires 1.45.106 on 1.45.x to complete the verification's on the remaining platforms once we get a 1.45.x RC.

@LaurenWags
Copy link
Member

LaurenWags commented Oct 19, 2022

Verified with

Brave | 1.45.106 Chromium: 107.0.5304.36 (Official Build) (x86_64)
-- | --
Revision | 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS | macOS Version 12.6 (Build 21G115)
Content settings - PASSED

Confirmed all expected items are listed on brave://settings/content page

1.44.112 1.45.106
1 44 112 1 45 106

Spot checked various settings on brave://settings/content page to confirm that as the settings were allowed/blocked they showed up.

Example, for Camera setting, confirmed when Don't allow sites to use your camera was selected under brave://settings/content/camera, I was not prompted for access my camera. When I clicked on the camera icon w/ red x in URL bar, it showed my camera as being blocked:

Example Example
Screen Shot 2022-10-19 at 1 51 06 PM Screen Shot 2022-10-19 at 1 50 57 PM

Example, for Camera setting, confirmed when Sites can ask to use your camera was selected under brave://settings/content/camera, I was prompted for access my camera. I selected "Allow" until site was closed, so it was listed under the allowed list. Once the site was closed, the site was removed from brave://settings/content/camera and I was again prompted when re-visiting the site.

Example Example Example Example Example
Screen Shot 2022-10-19 at 1 53 45 PM Screen Shot 2022-10-19 at 2 05 24 PM Screen Shot 2022-10-19 at 2 05 37 PM Screen Shot 2022-10-19 at 2 05 50 PM Screen Shot 2022-10-19 at 2 06 50 PM

Example, for Camera setting, confirmed when Sites can ask to use your camera was selected under brave://settings/content/camera, I was prompted for access my camera. I selected "Block" for 24h, so it was listed under the not allowed list. Once the site was closed, the site was not removed from brave://settings/content/camera and I was not prompted when re-visiting the site in the same day.

Example Example Example Example Example
Screen Shot 2022-10-19 at 1 53 45 PM Screen Shot 2022-10-19 at 2 26 26 PM Screen Shot 2022-10-19 at 2 28 00 PM Screen Shot 2022-10-19 at 2 28 28 PM Screen Shot 2022-10-19 at 2 28 53 PM

Spot checked content settings on upgrade from 1.44.112 --> 1.45.106 and confirmed settings were retained as expected.

1.44.112 1.45.106
1 2
3 4
5 6
7 8
Side panel - PASSED
  • Confirmed that sidebar is not shown by default in the release channel
  • Confirmed that Reading list icon is added to the sidebar menu
  • Confirmed that reading list panel is shown when user click on the Reading list icon in the sidebar menu
  • Confirmed that user can add the list of websites to the reading list by clicking on the +Add current tab
  • Confirmed that user can add the list of websites to the reading list by right clicking on the tab and choose the option Add tab to the reading list
  • Confirmed that reading list panel can be hidden by clicking on the Reading list icon in the sidebar menu
  • Confirmed that reading list icon is shown in the URL bar, next to wallet icon
  • Confirmed that user can enable/disable the reading list by clicking on the reading list icon (shown in the URL bar)
  • Confirmed that reading list is shown in all the window types (Normal, PT, TOR and Guest window)
  • Websites can't be added to reading list in Guest, encountered Unable to add a site to reading list in Guest window as Add to current tab option is not getting activated #24930
  • Confirmed that sites can be segregated to Read and Unread list
  • Confirmed that sites can be deleted from the reading list
Example Example Example Example Example
Screen Shot 2022-10-19 at 3 46 10 PM Screen Shot 2022-10-19 at 3 46 34 PM Screen Shot 2022-10-19 at 3 47 46 PM Screen Shot 2022-10-20 at 9 56 00 AM Screen Shot 2022-10-20 at 9 56 12 AM
Normal Private Tor Guest
2 3 4 5
Verify that file system access flag is still working as expected - PASSED
Step 5 Step 8 Step 10
5 8 10
Verify that vertical tabs experiment continues to work as expected - PASSED

Generally spot checked vertical tabs functionality:

  • Confirmed that vertical tabs get enabled when the flag #brave-vertical-tabs is enabled via brave://flags
  • Verified that sites can be added to vertical tab by clicking on the +
  • Right click on any site added in the vertical tab shown tab context menu options
  • Verified that reading list and vertical tabs cab be enabled at the same time
  • Right click on any site and select New tab to the right context menu option and ensured new tab got added to the right
  • Right click on any site and select Add tab to reading list context menu option and ensured site can be added to the reading list
  • Right click on any site and select Add a tab to new group and ensured that the selected site can be added to new tab group
  • Right click on any site in vertical tab and select Move tab to another window and ensured that tab is opened in an new window
  • Right click on any site in vertical tab and select Reload context menu option and ensured site gets reloaded/refreshed
  • Right click on any site in vertical tab and select Duplicate context menu option and ensured duplicate tab got added to the tab group
  • Right click on any site in vertical tab and select Pin context menu option and ensured site pinned in the tab group and right clicked on the pinned tab and ensured Unpin option is shown
  • Ensured that pinned site can be unpinned by clicking on the Unpin option
  • Right click on any YT site in vertical tab and select mute context menu option and ensured site is muted and mute option is shown in the URL bar and video is playing in a muted mode.
  • Ensured that YT videos can be unmuted by clicking on the Unmute option
  • Ensured that tabs can be drag and drop in an vertical tab
  • Ensured that vertical tab cab be collapsed/expanded, when vertical tabs is expand the tabs with site name and url is shown, when vertical tab cab be collapsed, the site favicons are shown in the vertical tabs
Example Example Example Example
1 2 3 4
Extensive internal changes to brave://settings (everything needs testing here, including toolbar) - PASSED

Performed default settings comparison on new profiles to ensure all settings were being displayed as expected with default values:

1.44.112 1.45.106
1 2
3 4
5 6
7 8
9 10
11 12
13 14
15 16
17 18
19 20
21 22
23 24
25 26
27 28
29 30
31 32
33 34
35 36
  • Confirmed that the link Import passwords and the text Create, save, and manage your passwords so you can easily sign in to sites and apps is been added in the brave://settings/passwords page as part of CR 107 (per discussion in slack)
  • Spot checked various settings to confirm they worked as expected
  • Confirmed all items in the toolbar (Settings, Brave Rewards, History, Bookmarks, Downloads, Wallet) opened the expected page when selected
  • Spot checked various settings were retained on upgrade from 1.44.112 --> 1.45.106

Skipped as they are Linux specific:

  • Minor Linux-related changes to system theme
  • Linux-related changes to Vulkan, enabled via Finch

@stephendonner
Copy link

stephendonner commented Oct 20, 2022

Verification PASSED using

Brave 1.45.108 Chromium: 107.0.5304.36 (Official Build) (x86_64)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS macOS Version 11.7 (Build 20G817)

I augmented #25658 (comment) with a few pref-state migrations from 1.44.112 -> 1.45.108.

Settings migrations:

IPFS - PASSED

  1. loaded ipns://brad.crypto
  2. clicked on Use a Brave local IPFS node
  3. confirmed the page loaded content
  4. also set IPFS public gateway fallback to On via brave://settings/ipfs
  5. upgraded to 1.45.108
  6. re-confirmed page loaded again successfully
  7. confirmed via brave://settings/ipfs prefs migrated properly
1.44.112 1.45.108
Screen Shot 2022-10-20 at 11 21 34 AM Screen Shot 2022-10-20 at 11 33 24 AM

Permissions - PASSED

  1. loaded https://permission.site/
  2. clicked on and enabled permissions for each of the following types:
    • Notifications
    • Location
    • Camera
    • Microphone
    • Camera + Microphone
  3. upgraded to 1.45.108
  4. loaded https://permission.site/
  5. clicked on each of the above permissions again, and confirmed they returned to Enabled (green color) without any additional permission prompts
1.44.112 1.45.108
Screen Shot 2022-10-20 at 11 23 49 AM Screen Shot 2022-10-20 at 11 35 14 AM

Tor - PASSED

  1. opened brave://settings/privacy
  2. toggled Automatically redirect .onion sites to Enabled
  3. toggled Use Bridges to Enabled
  4. left obfs4 as default built-in-bridge and clicked Apply
  5. loaded theguardian.com in a normal window
  6. confirmed it also loaded https://www.guardian2zotagl6tmjucg3lrhxdk4dw3lhbqnkvvkywawy3oqfoprid.onion/us in a new Private Window with Tor
  7. upgraded to 1.45.108
  8. confirmed the theguardian.com Tor page still loaded
  9. confirmed above changed pref settings persisted
1.44.112 1.45.108
Screen Shot 2022-10-20 at 11 24 35 AM Screen Shot 2022-10-20 at 11 37 14 AM

Search engines - PASSED

  1. opened brave://settings/search
  2. set Normal Window to DuckDuckGo
  3. set Private Window to DuckDuckGo
  4. toggled Web Discovery Project to Enabled
  5. toggled Index other search engines to Enabled
  6. searched in Private and normal windows (via the URL bar), and ensured I got DuckDuckGo
  7. upgraded to 1.45.108
  8. opened brave://settings/search and confirmed settings were intact
  9. searched again in Private and normal windows, and ensured I got DuckDuckGo
1.44.112 1.45.108
Screen Shot 2022-10-20 at 11 26 09 AM Screen Shot 2022-10-20 at 11 33 15 AM

DNS - PASSED

  1. opened brave://settings/security
  2. set the radio button under Use Secure DNS to With NextDNS
  3. confirmed pages loaded successfully, using NextDNS
  4. upgraded to 1.45.108
  5. re-confirmed pages loaded successfully, using NextDNS
  6. confirmed brave://settings/security was still set to Use Secure DNS With NextDNS
1.44.112 1.45.108
Screen Shot 2022-10-20 at 11 26 45 AM Screen Shot 2022-10-20 at 11 32 19 AM

@btlechowski
Copy link

btlechowski commented Oct 21, 2022

Verification passed on

Brave 1.45.109 Chromium: 107.0.5304.62 (Official Build) (64-bit)
Revision 1eec40d3a5764881c92085aaee66d25075c159aa-refs/branch-heads/5304@{#942}
OS Ubuntu 18.04 LTS
Content settings - PASSED

Confirmed all expected items are listed on brave://settings/content page
image

Spot checked various settings on brave://settings/content page to confirm that as the settings were allowed/blocked they showed up.

Example, for Mic setting, confirmed when Don't allow sites to use your mic was selected under brave://settings/content/microphone, I was not prompted for access my camera. When I clicked on the mic icon w/ red x in URL bar, it showed my camera as being blocked:

image
image

Example, for mic setting, confirmed when Sites can ask to use your mic was selected under brave://settings/content/microphone, I was prompted for access my mic . I selected "Allow" until site was closed, so it was listed under the allowed list. Once the site was closed, the site was removed from brave://settings/content/microphone and I was again prompted when re-visiting the site.

image
image
image
image

Example, for Mic setting, confirmed when Sites can ask to use your mic was selected under brave://settings/content/microphone, I was prompted for access my camera. I selected "Block" for 24h, so it was listed under the not allowed list. Once the site was closed, the site was not removed from brave://settings/content/microphone and I was not prompted when re-visiting the site in the same day.

image
image
image
image

Spot checked content settings on upgrade from 1.44.112 --> 1.45.x and confirmed settings were retained as expected.

Side panel - PASSED
  • Confirmed that sidebar is not shown by default in the release channel
  • Confirmed that Reading list icon is added to the sidebar menu
  • Confirmed that reading list panel is shown when user click on the Reading list icon in the sidebar menu
  • Confirmed that user can add the list of websites to the reading list by clicking on the +Add current tab
  • Confirmed that user can add the list of websites to the reading list by right clicking on the tab and choose the option Add tab to the reading list
  • Confirmed that reading list panel can be hidden by clicking on the Reading list icon in the sidebar menu
  • Confirmed that reading list icon is shown in the URL bar, next to wallet icon
  • Confirmed that user can enable/disable the reading list by clicking on the reading list icon (shown in the URL bar)
  • Confirmed that reading list is shown in all the window types (Normal, PT, TOR and Guest window)
  • Websites can't be added to reading list in Guest, encountered Unable to add a site to reading list in Guest window as Add to current tab option is not getting activated #24930
  • Confirmed that sites can be segregated to Read and Unread list
  • Confirmed that sites can be deleted from the reading list

Normal
image
image
image
image

Private - Tor - Guest
image
image
image

Verify that file system access flag is still working as expected - PASSED

image
image

Verify that vertical tabs experiment continues to work as expected - PASSED

Generally spot checked vertical tabs functionality:

  • Confirmed that vertical tabs get enabled when the flag #brave-vertical-tabs is enabled via brave://flags
  • Verified that sites can be added to vertical tab by clicking on the +
  • Right click on any site added in the vertical tab shown tab context menu options
  • Verified that reading list and vertical tabs cab be enabled at the same time
  • Right click on any site and select New tab to the right context menu option and ensured new tab got added to the right
  • Right click on any site and select Add tab to reading list context menu option and ensured site can be added to the reading list
  • Right click on any site and select Add a tab to new group and ensured that the selected site can be added to new tab group
  • Right click on any site in vertical tab and select Move tab to another window and ensured that tab is opened in an new window
  • Right click on any site in vertical tab and select Reload context menu option and ensured site gets reloaded/refreshed
  • Right click on any site in vertical tab and select Duplicate context menu option and ensured duplicate tab got added to the tab group
  • Right click on any site in vertical tab and select Pin context menu option and ensured site pinned in the tab group and right clicked on the pinned tab and ensured Unpin option is shown
  • Ensured that pinned site can be unpinned by clicking on the Unpin option
  • Right click on any YT site in vertical tab and select mute context menu option and ensured site is muted and mute option is shown in the URL bar and video is playing in a muted mode.
  • Ensured that YT videos can be unmuted by clicking on the Unmute option
  • Ensured that tabs can be drag and drop in an vertical tab
  • Ensured that vertical tab cab be collapsed/expanded, when vertical tabs is expand the tabs with site name and url is shown, when vertical tab cab be collapsed, the site favicons are shown in the vertical tabs

image
image

Extensive internal changes to brave://settings (everything needs testing here, including toolbar) - PASSED

Performed default settings comparison on new profiles to ensure all settings were being displayed as expected with default values.

image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image

  • Confirmed that the link Import passwords and the text Create, save, and manage your passwords so you can easily sign in to sites and apps is been added in the brave://settings/passwords page as part of CR 107
  • Spot checked various settings to confirm they worked as expected
  • Confirmed all items in the toolbar (Settings, Brave Rewards, History, Bookmarks, Downloads, Wallet) opened the expected page when selected
  • Spot checked various settings were retained on upgrade from 1.44.112 --> 1.45.x
Minor Linux-related changes to system theme - PASSED

We do not have system theme on Linux.
Spot checked our current behavior on release

image
image

image
image

Skipped per slack as they are Linux specific:

  • Linux-related changes to Vulkan, enabled via Finch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment