Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import stalls if Payments data if data exists in muon but Payments is turned off #2337

Closed
LaurenWags opened this issue Dec 3, 2018 · 1 comment · Fixed by brave/brave-core#1009

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Dec 3, 2018

Description

If you have a user in muon brave who had enabled Payments (wallet exists, etc) but then the user turned Payments off for whatever reason, when I go to import into b-c, Import stalls. I do not have any muon Brave windows open, so the import should succeed.

Steps to Reproduce

  1. Have a muon Brave profile set up where you have Payments data (wallet, etc). Turn off Payments.
  2. Close muon Brave.
  3. Ensure you don't have any Brave-Browser profile for b-c Brave.
  4. Restart your machine (to be extra sure no muon Brave processes are hanging around)
  5. After restart, Launch 0.57.12. I did this from the terminal with /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --enable-logging=stderr --v=0 --vmodule=*rewards*=6
  6. Import only Payments data from Brave (Brave > Import Bookmarks and Settings > choose Brave (old) > only have Payments checked

Actual result:

Import appears to stall. You just get a spinner on the import window.
screen shot 2018-12-03 at 3 26 13 pm

This displays in terminal:

[891:19203:1203/152148.392986:ERROR:brave_importer.cc(363)] Wallet passphrase not found in session-store-1
[891:19203:1203/152148.393056:ERROR:brave_importer.cc(602)] Failed to parse wallet passphrase

Expected result:

I'd guess that Payments data (wallet) should be imported but Auto Contribute should be disabled.
Payments import will be skipped. No wallet or settings will be imported. See updated pt 11 on Test Plan from brave/brave-core#736

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.57.12 Chromium: 71.0.3578.75 (Official Build) (64-bit)
Revision 06ef00b5279f93f8e0c1e73acedd49d7dcc09767-refs/branch-heads/3578@{#836}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@LaurenWags LaurenWags added this to the 0.57.x - Release milestone Dec 3, 2018
bsclifton added a commit to brave/brave-core that referenced this issue Dec 3, 2018
- if session-store-1 and ledger-state.json are missing, skip import
- if rewards is disabled, skip import
- if passphrase or other key fields are missing, skip import

In each of these cases, an error is still logged (to console). But it won't hang the import anymore.

Fixes brave/brave-browser#2337
@LaurenWags
Copy link
Member Author

LaurenWags commented Dec 5, 2018

Verified passed with

Brave 0.57.16 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X
  • Verified STR in description (manually importing Payments data) and also launching from terminal with --upgrade-from-muon flag.

Verified Passed on

Brave 0.57.16 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows 7

Verified importing manually and through the flag --upgrade-from-muon

Verification passed on

Brave 0.57.18 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment