Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-contribute table clears at the beginning of the month #2333

Closed
LaurenWags opened this issue Dec 3, 2018 · 1 comment · Fixed by brave/brave-core#1023
Closed

auto-contribute table clears at the beginning of the month #2333

LaurenWags opened this issue Dec 3, 2018 · 1 comment · Fixed by brave/brave-core#1023

Comments

@LaurenWags
Copy link
Member

Description

Auto Contribute table clears at the beginning of the month. If you have sites populated in the table, when the new month starts, your table appears blank in the UI even if you are not set to contribute until later in the month.

Steps to Reproduce

  1. Have a profile with rewards enabled and sites populated in the auto-contribute table. Verify your contribution date is at least several days after the beginning of the month.
  2. Wait until the beginning of the month.
  3. Launch Brave

Actual result:

Auto-contribute table is blank, but your contribution date is still the same (mine is Dec 7)

Expected result:

Table should not be cleared until contribution has happened.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.56.15 Chromium: 70.0.3538.110 (Official Build) (64-bit)
Revision ca97ba107095b2a88cf04f9135463301e685cbb0-refs/branch-heads/3538@{#1094}
OS Mac OS X
Brave 0.58.10 Chromium: 71.0.3578.53 (Official Build) dev(64-bit)
Revision 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? yes, reproduced on dev

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

cc @brave/legacy_qa for verification on other platforms

@LaurenWags
Copy link
Member Author

LaurenWags commented Dec 19, 2018

Verified passed with

Brave 0.58.15 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Mac OS X
  • Verified Test Plan from Fixes ac table when month changes brave-core#1023 with the following modification: wallet could not be created in the past, had to change computer to today's date to create wallet, then change it back to Nov to add sites. As a result, my contribution date is in January, not December.
  • Checked publisher_info_db to confirm that sites were "added" in November:
    screen shot 2018-12-19 at 1 07 18 pm
  • After computer clock was updated to current date/time, sites remained in table and were not cleared out:
    screen shot 2018-12-19 at 1 11 53 pm

Verification passed on

Brave 0.58.15 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Windows
  • Verified Test Plan from Fixes ac table when month changes brave-core#1023. Changed the clock to previous month (Nov 2018) i was unable enable the rewards. Hence changed the clock to today's date and enabled wallet and then changed clock to previous month (Nov 2018). Added couple of non http sites to Rewards table and verified that Next contribution date displayed as Jan 2019
  • Verified the publisher_info_db to check sites were added to table.

image

  • Reset the clock time to today's date and time (19 dec), added sites remained in rewards table both on UI as well as on publisher_info_db

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants