Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no feedback/indicator when copying phrase from Your recovery phrase screen #19021

Closed
kjozwiak opened this issue Oct 27, 2021 · 2 comments · Fixed by brave/brave-core#11535
Closed

Comments

@kjozwiak
Copy link
Member

Description

When a user clicks on Copy via the Your recovery phrase during wallet creation, there's no UI indicators that let the user know that the phrase was copied in the clipboard. I needed to paste it into a text file/URL bar to make sure it was actually copied before moving on the next step.

I think we should fix this for the initial launch as users might get nervous if they don't see any feedback when it comes to copying their phrase.

Even better, offer a way to export the key via a text file along side the Copy option. Let me know if this is a good idea and we can create a new issue/feature suggestion.

Steps to Reproduce

  1. launch Brave and enable brave://wallet (new implementation)
  2. run through wallet creation till you reach the Your recovery phrase phase
  3. click on Copy and notice there's no UI/UX indicators that the phrase was actually copied.

Actual result:

When clicking on Copy, there's no UI/UX indicator that anything was actually copied into the clipboard.

Expected result:

We should have some type of UI/UX indicator that lets users know that their phrase was copied/added into the clipboard.

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave | 1.33.34 Chromium: 95.0.4638.54 (Official Build) nightly (64-bit)
-- | --
Revision | d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS | Windows 11 Version 21H2 (Build 22000.258)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 29, 2021
@muliswilliam muliswilliam self-assigned this Dec 3, 2021
@muliswilliam muliswilliam added this to the 1.35.x - Nightly milestone Dec 9, 2021
@stephendonner
Copy link

Verified PASSED using

Brave 1.35.56 Chromium: 97.0.4692.56 (Official Build) nightly (64-bit)
Revision 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS Windows 10 Version 20H2 (Build 19042.1415)

Confirmed I got a Copied feedback message.

example example
copy-1 copy-2

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.35.82 Chromium: 97.0.4692.71 (Official Build) beta (64-bit)
Revision 1adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}1
OS Windows 11 Version Dev (Build 22523.1000)
  • Verified test plan from brave/brave-core#11535
  • Verified clicking on the copy button changes the text from Copy to Copied
  • Verified after 5 seconds it reverts back to Copy
  • Verified works during onboarding and when doing manual backup
  • Logged follow up issue #20470
Onboarding (Copy) Onboarding (Copied) Backup Wallet (Copy) Backup Wallet (Copied)
image image image image

Verification passed on

Brave 1.35.82 Chromium: 97.0.4692.71 (Official Build) beta (64-bit)
Revision 1adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}1
OS Linux
  • Verified test plan from brave/brave-core#11535
  • Verified clicking on the copy button changes the text from Copy to Copied
  • Verified after 5 seconds it reverts back to Copy
  • Verified works during onboarding and when doing manual backup
  • Logged follow up issue #20470
Onboarding (Copy) Onboarding (Copied) Backup Wallet (Copy) Backup Wallet (Copied)
image image image image

Verification passed on

Brave 1.35.82 Chromium: 97.0.4692.71 (Official Build) beta (arm64)
Revision 1adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}1
OS macOS Version 12.1 (Build 21C52)
  • Verified test plan from brave/brave-core#11535
  • Verified clicking on the copy button changes the text from Copy to Copied
  • Verified after 5 seconds it reverts back to Copy
  • Verified works during onboarding and when doing manual backup
  • Logged follow up issue #20470
Onboarding (Copy) Onboarding (Copied) Backup Wallet (Copy) Backup Wallet (Copied)
image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants