Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import additional data related to referral promo and retention tracking for continuity with Muon #1884

Closed
davidtemkin opened this issue Oct 29, 2018 · 1 comment · Fixed by brave/brave-core#935

Comments

@davidtemkin
Copy link

davidtemkin commented Oct 29, 2018

Test plan

See brave/brave-core#935

Description

In addition to importing the promoCode, we need to import the the following data when importing from Muon to Brave-core:

-- Date of install for referral promo-- this is used to determine the date of the 30-day realization ping for browsers installed via referral promo. The installation date should not be reset upon upgrade, but stay on the same realization schedule that the user had be on when they installed Muon.

-- "week of install" used for retention tracking -- this is used whether or not a browser has been installed via referral promo, and is used to determine retention rates for a given user over time -- even if they are upgraded to Brave Core. So, the desired behavior would be that upon upgrading from Muon to Brave Core, a given user would retain the same "week of install" from their initial installation (of Muon). (I believe this data is cleared after 90 days, so not all Muon profiles will contain this data).

@aekeus -- Have I overlooked any information here? We already import the promo code itself.

@bbondy bbondy modified the milestones: 1.x Backlog, Muon => Brave Core migration Oct 30, 2018
@bbondy bbondy modified the milestones: Muon => Brave Core migration, 1.x Backlog Oct 30, 2018
@bsclifton bsclifton modified the milestones: 1.x Backlog, 0.56.x - Release Hotfix 1 Nov 6, 2018
bsclifton added a commit to brave/brave-core that referenced this issue Nov 21, 2018
…hey are available) and set corresponding values in brave-core.

Fixes brave/brave-browser#1884
Fixes brave/brave-browser#1294
@LaurenWags
Copy link
Member

LaurenWags commented Dec 5, 2018

Verified passed with

Brave 0.57.16 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X

Verification Passed on

Brave 0.57.17 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows 7

Used test plan from brave/brave-core#935

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment