Decrease height of download bar by showing source on hover #1638

srirambv · 2018-10-17T01:49:20Z

Description

Users are complaining about the download bar being too tall. Download may be integrated into sidebar in the future, but do a short term quick fix by only showing the source on hover.

Original description:

Visually download bar looks really big and is a distraction on UI. This was a problem on muon as well and users complained about it as well. With added URL info on downloads the size has doubled from normal. Definitely needs a redesign for download bar

Steps to Reproduce

Install 0.55.14
Download a file
Regret downloading file which makes you look at that huge download bar

Actual result:

While downloading

After download complete

Expected result:

Do not show the source by default:

Show the only source on hover (source replaces the title):

Reproduces how often:

Easily

Brave version (brave://version info)

All versions

Version/Channel Information:

Can you reproduce this issue with the current release? Yes
Can you reproduce this issue with the beta channel? Yes
Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields? N/A
Does the issue resolve itself when disabling Brave Rewards? N/A
Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@bradleyrichter @rossmoody @karenkliu @bbondy @brave/legacy_qa

bbondy · 2018-10-17T02:32:04Z

note that this was a blocker from security to have this information, so we don't want to remove it with a new design. cc @diracdeltas

bradleyrichter · 2018-10-17T05:42:16Z

needs a UX review to see if there is a solution that makes everyone happy.

diracdeltas · 2018-10-17T06:45:57Z

maybe show the origin and/or the progress text on hover instead of in the area?

srirambv · 2018-11-02T02:08:35Z

+1 on hover behaviour. Honestly its too distracting when there are multiple downloads going on

jonathansampson · 2019-04-21T20:40:31Z

I received a ping from a user via Twitter today asking that we consider UI changes. This user also encourages us to consider Safari's approach.

Brave-Matt · 2019-05-06T21:43:29Z

+1 from reddit:
https://www.reddit.com/r/brave_browser/comments/bkzz5u/customizing_the_browser_to_fix_a_few_glaring/

Brave-Matt · 2019-05-06T23:44:50Z

+1 from reddit:
https://www.reddit.com/r/brave_browser/comments/bljeqj/the_download_bar_seems_really_large_is_there_a/

Neo23x0 · 2020-10-28T11:54:19Z

Any news on this?

Brave-Matt · 2021-06-29T18:41:20Z

Another Community +1:
https://community.brave.com/t/download-complete-notification-takes-way-to-much-space/263121

@rebron can we take a look at this and see if this is something to be adjusted? It's minor (even aesthetically) but has been brought up consistently since switching to Chromium and is certainly worth considering an adjustment if not a redesign.

JFMugen · 2021-06-29T19:58:28Z

Yeah, PLEASE.

y4rr · 2021-07-28T19:38:33Z

The big irony is that there's screen space to show both file name and its url three times one after another in a row, but nobody seems to notice.

Why do file name and file url have to be trimmed to the length when both of them are not meaningful? @rebron

bsclifton · 2021-08-02T07:52:08Z

@JFMugen I'm happy to report that you'll no longer be surprised OR annoyed; @nullhook did a great job solving this and the fix will bein the next Nightly 😄

This will work it's way through the channels; 1.29 is due to be released (stable) on August 31st

JFMugen · 2021-08-02T08:59:40Z

@bsclifton Yeah, I have been following it since he started to work on it :D

Thank you very much @nullhook :)

stephendonner · 2021-08-02T22:36:28Z

Verified FIXED using

Brave	1.29.45 Chromium: 92.0.4515.115 (Official Build) nightly (x86_64)
Revision	48cb2f4029b84b003719740a6cf9ca73f374a857-refs/branch-heads/4515_105@{#4}
OS	macOS Version 12.0 (Build 21A5294g)

Steps:

new profile
launched Brave
context-clicked on the file-size buttons and downloaded files from https://www.leaseweb.com/platform/network
clicked on keep after getting This file can't be downloaded securely message
did cancel, pause, resume, discard and file-downloaded scenarios
tested in both Light and Dark colors
confirmed the origin URL shows up only on hover

light

dark

height comparison (bottom) to current 1.27.109 release (top)

Verification passed on

Brave	1.29.60 Chromium: 92.0.4515.131 (Official Build) beta (64-bit)
Revision	6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS	Ubuntu 18.04 LTS

Verified the origin URL shows up only on hover

light:

dark:

Verification passed on

Brave | 1.29.60 Chromium: 92.0.4515.131 (Official Build) beta (64-bit)
-- | --
Revision | 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS | Windows 10 OS Version 2009 (Build 19043.1165)

Confirmed cancel, pause, resume, discard and file-downloaded scenarios works as expected

Light Theme:

Dark Theme:

Confirmed the origin URL shows up only on hover

height comparison (bottom) 1.29.x to current 1.28.x release (top), confirmed height of the download bar is reduced in 1.29.x

When downloading a large file the DownloadItemView is supposed to show certain information about the item being downloaded, such as the name and the current status. Additionally, it's also meant to show the URL but, due to changes done recently in PR 9521 [1] (see issue in [2]), Brave contains changes to only show the URL when hovering over the download item view, to save space. Turns out that these changes were causing a crash after a the change below landed upstream and the reason seems to be that our chromium_src override was wrongly redefining the Button symbol way beyond the scope of download_item_view.cc, causing the crash. This change includes the necessary headers from download_item_view.cc to avoid this Button redefinition from propagating any further, and also makes the most of the effort to fix some small things in the override file, such as calling the parent methods of the overriden methods from the Button class, or adding some extra documentation. Last, this change also fixes 2 crashing browser tests: * BraveCheckClientDownloadRequestBaseBrowserTest.FilterRequest * SavePackageFinishedObserverBrowserTest.Success [1] #9521 [2] brave/brave-browser#1638 Chromium change: https://source.chromium.org/chromium/chromium/src/+/03f006384e02fb387c177af07a3df9792e364e18 commit 03f006384e02fb387c177af07a3df9792e364e18 Author: Peter Kasting <[email protected]> Date: Thu Jul 22 00:45:59 2021 +0000 Clicking the download item context button should close any open menu. This is what other buttons in Chrome do: repeatedly clicking the button toggles it between open and closed, instead of flickering it closed and instantly reopening (the current behavior). Bug: 1031682

srirambv added feature/user-interface All UI related design A design change, especially one which needs input from the design team feature/download design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. labels Oct 17, 2018

srirambv added this to the 1.x Backlog milestone Oct 17, 2018

rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Oct 19, 2018

kjozwiak added the QA/Yes label Nov 5, 2018

karenkliu self-assigned this Dec 4, 2018

rebron removed this from the 1.x Backlog milestone Feb 7, 2019

rebron removed the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Jun 24, 2020

rebron self-assigned this Jul 7, 2020

rebron mentioned this issue Aug 7, 2020

[Desktop] Feature Request : smaller or inobtrusive download status bar #10377

Closed

rebron removed the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Jul 16, 2021

nullhook self-assigned this Jul 16, 2021

karenkliu removed their assignment Jul 21, 2021

rebron removed their assignment Jul 21, 2021

nullhook mentioned this issue Jul 21, 2021

Decrease download shelf height and show origin url on hover brave/brave-core#9521

Merged

24 tasks

nullhook closed this as completed in brave/brave-core#9521 Aug 2, 2021

bsclifton added this to the 1.29.x - Nightly milestone Aug 2, 2021

nullhook added release-notes/include OS/Desktop labels Aug 2, 2021

stephendonner added QA/Test-Plan-Specified QA Pass-macOS labels Aug 2, 2021

mariospr mentioned this issue Aug 6, 2021

Crash on Chromium 94-based Brave when downloading large files. #17386

Closed

mariospr mentioned this issue Aug 6, 2021

Fix crash downloading large files due to the DownloadItemView brave/brave-core#9688

Merged

24 tasks

LaurenWags added the QA/Test-All-Platforms label Aug 12, 2021

btlechowski added the QA Pass-Linux label Aug 16, 2021

GeetaSarvadnya added the QA Pass-Win64 label Aug 16, 2021

LaurenWags mentioned this issue Aug 30, 2021

[Desktop] Release Notes for 1.29.x Release #1 #17767

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Decrease height of download bar by showing source on hover #1638

Decrease height of download bar by showing source on hover #1638

srirambv commented Oct 17, 2018 •

edited by karenkliu

Loading

bbondy commented Oct 17, 2018

bradleyrichter commented Oct 17, 2018

diracdeltas commented Oct 17, 2018

srirambv commented Nov 2, 2018

jonathansampson commented Apr 21, 2019

Brave-Matt commented May 6, 2019

Brave-Matt commented May 6, 2019

Neo23x0 commented Oct 28, 2020

Brave-Matt commented Jun 29, 2021 •

edited

Loading

JFMugen commented Jun 29, 2021

y4rr commented Jul 28, 2021

bsclifton commented Aug 2, 2021

JFMugen commented Aug 2, 2021

stephendonner commented Aug 2, 2021 •

edited by GeetaSarvadnya

Loading

Decrease height of download bar by showing source on hover #1638

Decrease height of download bar by showing source on hover #1638

Comments

srirambv commented Oct 17, 2018 • edited by karenkliu Loading

Description

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

bbondy commented Oct 17, 2018

bradleyrichter commented Oct 17, 2018

diracdeltas commented Oct 17, 2018

srirambv commented Nov 2, 2018

jonathansampson commented Apr 21, 2019

Brave-Matt commented May 6, 2019

Brave-Matt commented May 6, 2019

Neo23x0 commented Oct 28, 2020

Brave-Matt commented Jun 29, 2021 • edited Loading

JFMugen commented Jun 29, 2021

y4rr commented Jul 28, 2021

bsclifton commented Aug 2, 2021

JFMugen commented Aug 2, 2021

stephendonner commented Aug 2, 2021 • edited by GeetaSarvadnya Loading

srirambv commented Oct 17, 2018 •

edited by karenkliu

Loading

Brave-Matt commented Jun 29, 2021 •

edited

Loading

stephendonner commented Aug 2, 2021 •

edited by GeetaSarvadnya

Loading