Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop associating Brave with the ftp protocol #15812

Closed
fmarier opened this issue May 13, 2021 · 6 comments · Fixed by brave/brave-core#8791
Closed

Stop associating Brave with the ftp protocol #15812

fmarier opened this issue May 13, 2021 · 6 comments · Fixed by brave/brave-core#8791

Comments

@fmarier
Copy link
Member

fmarier commented May 13, 2021

Chromium removed ftp support from the codebase in M91, but it is still included in the desktop shortcut on Linux and so it gets used when opening ftp URLs:

xdg-mime query default x-scheme-handler/ftp

Upstream meta-bug: https://bugs.chromium.org/p/chromium/issues/detail?id=333943

@fmarier
Copy link
Member Author

fmarier commented May 19, 2021

I have filed a bug upstream for this: https://bugs.chromium.org/p/chromium/issues/detail?id=1210977

@fmarier
Copy link
Member Author

fmarier commented May 19, 2021

@btlechowski
Copy link

Added QA/Blocked till we get a release build.

@LaurenWags
Copy link
Member

Removed QA/Blocked, release preview version is available: https://github.com/brave/brave-browser/releases/tag/v1.26.63

@btlechowski
Copy link

btlechowski commented Jun 18, 2021

Verification passed on

Brave 1.26.63 Chromium: 91.0.4472.106 (Official Build) (64-bit)
Revision 574f7b38e4e7244c92c4675e902e8f8e3d299ea7-refs/branch-heads/4472@{#1477}
OS Ubuntu 20 LTS

Verified that after Ubuntu 20 installation, Firefox is associated with the protocols:
image
Verified that after installing Brave 1.26.x (release channel) and restarting the system, Brave is not associated with the protocols
image

Verified that on existing Brave installations, after installing Brave 1.26.x (release channel), Brave is no longer associated with the protocols

@mowny
Copy link

mowny commented Feb 2, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants