Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the "Block element via selector" from the brave extension #15419

Closed
kkuehlz opened this issue Apr 21, 2021 · 0 comments · Fixed by brave/brave-core#8595
Closed

Remove the "Block element via selector" from the brave extension #15419

kkuehlz opened this issue Apr 21, 2021 · 0 comments · Fixed by brave/brave-core#8595
Assignees
@kkuehlz
Labels
feature/CSS-element-block feature/shields/adblock Blocking ads & trackers with Shields OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/include
Milestone
1.26.x - Release

Comments

@kkuehlz
Copy link
Contributor

kkuehlz commented Apr 21, 2021

Remove the "Block element via selector" from the brave extension.

By resolving #13808 we added an element picker mode, which is much easier for users than creating the CSS selector rules by hand. Furthermore, the element picker allows for users to hand-modify any generated rules, so the functionality is subsumed.
@kkuehlz kkuehlz self-assigned this Apr 21, 2021
@kkuehlz kkuehlz added feature/shields/adblock Blocking ads & trackers with Shields OS/Desktop QA/No feature/CSS-element-block priority/P3 The next thing for us to work on. It'll ride the trains. labels Apr 21, 2021
@kkuehlz kkuehlz mentioned this issue Apr 21, 2021
Merged
24 tasks
kkuehlz pushed a commit to brave/brave-core that referenced this issue Apr 22, 2021
Remove block element via selector
6d35280 
This functionality has be subsumed by the element picker.

Resolves brave/brave-browser#15419
kkuehlz pushed a commit to brave/brave-core that referenced this issue Apr 23, 2021
Remove block element via selector
33b487b 
This functionality has be subsumed by the element picker.

Resolves brave/brave-browser#15419
@kkuehlz kkuehlz added this to the 1.26.x - Nightly milestone Apr 30, 2021
@kkuehlz kkuehlz mentioned this issue May 5, 2021
Closed
@LaurenWags LaurenWags mentioned this issue Jun 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkuehlz kkuehlz

Labels
feature/CSS-element-block feature/shields/adblock Blocking ads & trackers with Shields OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/include
Projects
None yet
Milestone
1.26.x - Release
Development

Successfully merging a pull request may close this issue.

Remove block element via selector brave/brave-core
1 participant
@kkuehlz