Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewards and other custom chrome:// pages need favicon #1466

Closed
LaurenWags opened this issue Oct 9, 2018 · 7 comments
Closed

rewards and other custom chrome:// pages need favicon #1466

LaurenWags opened this issue Oct 9, 2018 · 7 comments

Comments

@LaurenWags
Copy link
Member

Description

Custom chrome:// pages need favicons. For pages like Rewards, which is included in the on-boarding flow, this should be done sooner rather than later, it looks bad without a favicon.

Steps to Reproduce

  1. Navigate to chrome://rewards or chrome://adblock

Actual result:

No favicon:
screen shot 2018-10-09 at 7 36 57 am

Expected result:

Custom pages should have favicon like welcome page.

Reproduces how often:

easy

Brave version (chrome://version info)

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta(64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? yes
  • Does it reproduce on browser-laptop? n/a

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

Similar to #1278 but that issue is specific to Task Manager.

@LaurenWags LaurenWags added the feature/user-interface All UI related label Oct 9, 2018
@LaurenWags LaurenWags added this to the 1.0 (0.56.x) milestone Oct 9, 2018
@rebron rebron modified the milestones: 1.0, 0.56.x - Beta Oct 16, 2018
@srirambv
Copy link
Contributor

Action items from @davidtemkin

We should create new favicons (most obviously visible in tabs, but also potentially in bookmarks, etc) for pages like:

-- Rewards (currently a generic document icon)
-- Settings (currently the Chrome-default icon)

I assume there are others.

It looks like we already have such an icon for brave://welcome, which is great.

@NejcZdovc
Copy link
Contributor

fixes in brave/brave-core#756

@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.59.x - Dev Dec 6, 2018
@LaurenWags
Copy link
Member Author

@rossmoody @NejcZdovc could one of you add a test plan for this issue please?

@NejcZdovc
Copy link
Contributor

@LaurenWags test plan is quite simple. Go to rewards setting page and make sure that settings tab has rewards logo as favicon

image

@LaurenWags
Copy link
Member Author

thanks @NejcZdovc ! Wasn't sure if other pages were included with this issue as well.

@rossmoody
Copy link
Contributor

Yeah maybe the scope of this one could be just for the rewards favico. We have a similar issue with a larger collection that might need revisited soon: #1278

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 27, 2018

Verification pased on

Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Windows

Verrification passed on

Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Linux

  • Verified the STR mentioned in the description
    image

Verification passed with

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment