Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats and referrals call ProfileManager::GetPrimaryUserProfile without waiting for profile initialization to complete #14594

Closed
bridiver opened this issue Mar 9, 2021 · 2 comments · Fixed by brave/brave-core#8196

Comments

@bridiver
Copy link
Contributor

bridiver commented Mar 9, 2021

Early initialization of the profiles could cause a wide range of problems and it's not clear what issues it may or may not be causing now, but it's clearly a problem that needs to be addressed

QA should check regular and referral pings for correctness

@LaurenWags
Copy link
Member

LaurenWags commented Mar 15, 2021

Verified passed with

Brave | 1.21.77 Chromium: 89.0.4389.90 (Official Build) (x86_64)
-- | --
Revision | 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS | macOS Version 10.15.7 (Build 19H524)

As per #14594 (comment), basically ensured that usage & referral pings are still working as per the following:

Usage pings

initial launch 30 days after install Ads enabled
initial launch 30 days after install Ads Enabled

Referral pings

initial launch 24hrs after install 30 days after install 90 days after install
referral - initial launch referral - 24h after install referral - 30d after install referral-90d after install

Note - I do not see the "30 days complete event" like @kjozwiak did in brave/brave-core#8196 (comment), however this is also the case in 1.21.76 so no difference there.


Verification passed on

Brave 1.21.77 Chromium: 89.0.4389.90 (Official Build) (64-bit)
Revision 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS Ubuntu 18.04 LTS

As per #14594 (comment), basically ensured that usage & referral pings are still working as per the following:

Usage pings

initial launch 30 days after install Ads enabled
image image image

No ref codes on Linux


Verification passed on


Brave | 1.21.77 Chromium: 89.0.4389.90 (Official Build) (64-bit)
-- | --
Revision | 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS | Windows 10 OS Version 2004 (Build 19041.867)


As per #14594 (comment), basically ensured that usage & referral pings are still working as per the following:

Usage pings

initial launch 30 days after install Ads enabled
image image image

Referral pings

initial launch 24hrs after install 30 days after install 90 days after install
image image image image

@srirambv
Copy link
Contributor

srirambv commented Mar 15, 2021

Verification passed on OnePlus 6T with Android 10 running 1.21.77 x64 build

  • Verified usage pings are still working as expected
Initial Launch 30 Days after install Ads enabled
image image image

Verification passed on Samsung Samsung Galaxy Tab S5e with Android 9 running 1.21.77 x64 build

  • Verified usage pings are still working as expected
Initial Launch 30 Days after install Ads enabled
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment