breakpad_linux: backtrace ids fail and no linux crash ids are written locally to the users upload.log file #14326
Assignees
Milestone
Comments
kkuehlz
pushed a commit
to brave/brave-core
that referenced
this issue
Feb 23, 2021
Resolves brave/brave-browser#14326 This patch fixes breakpad to write crash ids to the file Crash\ Reports/uploads.log. The old behavior was to silently fail at this step since the backtrace crash Ids don't match Google crash ids. Fixes: * Increase the size of the string kCrashIdLength from 16 to 36 because backtrace crash ids are longer than chromium crash ids. * Allow a dash in the id since the backtrace crash id format is: xxxxxxxx-xxxx-xxxx-0000-000000000000, where "x" is a hexadecimal character.
17 tasks
btlechowski
added
the
QA/In-Progress
|
Changed the milestone as the issue is fixed on 1.23.x and not on 1.22.x. I checked the commit history to confirm. |
|
Verification passed on
Verified test plan from the description
|
btlechowski
added
QA Pass-Linux
and removed
QA/In-Progress
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this issue
Nov 1, 2023
This patch was introduced in the past to accept a backtrace. Recently though changes upstream changed exactly the patched lines in question to use an algorithm-based approach to check for the format of the ID. This change creates a local function in a shadow file to act as a proxy to make sure we preserve the `-` check as well as a valid id character. Original issue: brave/brave-browser#14326 Chromium change: https://chromium.googlesource.com/chromium/src/+/b999986ff24699b81ecd3f45254a4bdf0332698a commit b999986ff24699b81ecd3f45254a4bdf0332698a Author: Peter Kasting <[email protected]> Date: Wed Oct 25 03:54:27 2023 +0000 Shorten code by using existing helper APIs, eliminating temps. No functional change. Bug: none
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this issue
Nov 8, 2023
This patch was introduced in the past to accept a backtrace. Recently though changes upstream changed exactly the patched lines in question to use an algorithm-based approach to check for the format of the ID. This change creates a local function in a shadow file to act as a proxy to make sure we preserve the `-` check as well as a valid id character. Original issue: brave/brave-browser#14326 Chromium change: https://chromium.googlesource.com/chromium/src/+/b999986ff24699b81ecd3f45254a4bdf0332698a commit b999986ff24699b81ecd3f45254a4bdf0332698a Author: Peter Kasting <[email protected]> Date: Wed Oct 25 03:54:27 2023 +0000 Shorten code by using existing helper APIs, eliminating temps. No functional change. Bug: none
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this issue
Nov 10, 2023
This patch was introduced in the past to accept a backtrace. Recently though changes upstream changed exactly the patched lines in question to use an algorithm-based approach to check for the format of the ID. This change creates a local function in a shadow file to act as a proxy to make sure we preserve the `-` check as well as a valid id character. Original issue: brave/brave-browser#14326 Chromium change: https://chromium.googlesource.com/chromium/src/+/b999986ff24699b81ecd3f45254a4bdf0332698a commit b999986ff24699b81ecd3f45254a4bdf0332698a Author: Peter Kasting <[email protected]> Date: Wed Oct 25 03:54:27 2023 +0000 Shorten code by using existing helper APIs, eliminating temps. No functional change. Bug: none
mkarolin
pushed a commit
to brave/brave-core
that referenced
this issue
Nov 11, 2023
This patch was introduced in the past to accept a backtrace. Recently though changes upstream changed exactly the patched lines in question to use an algorithm-based approach to check for the format of the ID. This change creates a local function in a shadow file to act as a proxy to make sure we preserve the `-` check as well as a valid id character. Original issue: brave/brave-browser#14326 Chromium change: https://chromium.googlesource.com/chromium/src/+/b999986ff24699b81ecd3f45254a4bdf0332698a commit b999986ff24699b81ecd3f45254a4bdf0332698a Author: Peter Kasting <[email protected]> Date: Wed Oct 25 03:54:27 2023 +0000 Shorten code by using existing helper APIs, eliminating temps. No functional change. Bug: none
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this issue
Nov 16, 2023
This patch was introduced in the past to accept a backtrace. Recently though changes upstream changed exactly the patched lines in question to use an algorithm-based approach to check for the format of the ID. This change creates a local function in a shadow file to act as a proxy to make sure we preserve the `-` check as well as a valid id character. Original issue: brave/brave-browser#14326 Chromium change: https://chromium.googlesource.com/chromium/src/+/b999986ff24699b81ecd3f45254a4bdf0332698a commit b999986ff24699b81ecd3f45254a4bdf0332698a Author: Peter Kasting <[email protected]> Date: Wed Oct 25 03:54:27 2023 +0000 Shorten code by using existing helper APIs, eliminating temps. No functional change. Bug: none
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this issue
Nov 17, 2023
This patch was introduced in the past to accept a backtrace. Recently though changes upstream changed exactly the patched lines in question to use an algorithm-based approach to check for the format of the ID. This change creates a local function in a shadow file to act as a proxy to make sure we preserve the `-` check as well as a valid id character. Original issue: brave/brave-browser#14326 Chromium change: https://chromium.googlesource.com/chromium/src/+/b999986ff24699b81ecd3f45254a4bdf0332698a commit b999986ff24699b81ecd3f45254a4bdf0332698a Author: Peter Kasting <[email protected]> Date: Wed Oct 25 03:54:27 2023 +0000 Shorten code by using existing helper APIs, eliminating temps. No functional change. Bug: none
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this issue
Nov 24, 2023
This patch was introduced in the past to accept a backtrace. Recently though changes upstream changed exactly the patched lines in question to use an algorithm-based approach to check for the format of the ID. This change creates a local function in a shadow file to act as a proxy to make sure we preserve the `-` check as well as a valid id character. Original issue: brave/brave-browser#14326 Chromium change: https://chromium.googlesource.com/chromium/src/+/b999986ff24699b81ecd3f45254a4bdf0332698a commit b999986ff24699b81ecd3f45254a4bdf0332698a Author: Peter Kasting <[email protected]> Date: Wed Oct 25 03:54:27 2023 +0000 Shorten code by using existing helper APIs, eliminating temps. No functional change. Bug: none
mkarolin
pushed a commit
to brave/brave-core
that referenced
this issue
Nov 27, 2023
This patch was introduced in the past to accept a backtrace. Recently though changes upstream changed exactly the patched lines in question to use an algorithm-based approach to check for the format of the ID. This change creates a local function in a shadow file to act as a proxy to make sure we preserve the `-` check as well as a valid id character. Original issue: brave/brave-browser#14326 Chromium change: https://chromium.googlesource.com/chromium/src/+/b999986ff24699b81ecd3f45254a4bdf0332698a commit b999986ff24699b81ecd3f45254a4bdf0332698a Author: Peter Kasting <[email protected]> Date: Wed Oct 25 03:54:27 2023 +0000 Shorten code by using existing helper APIs, eliminating temps. No functional change. Bug: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Steps to Reproduce
brave://inducebrowsercrashforrealzActual result:
The backtrace report id is truncated on stdout, and nothing is written to the file
~/.config/BraveSoftware/Brave-Browser-Development/Crash\ Reports/uploads.logExpected result:
Crash dump id is not truncated. The file
~/.config/BraveSoftware/Brave-Browser-Development/Crash\ Reports/uploads.loghas a new line with the ID983b0000-ab7a-e305-0000-000000000000Reproduces how often:
Always
Brave version (brave://version info)
All versions
Version/Channel Information:
Affects all channels
The text was updated successfully, but these errors were encountered: