Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable or remove first-party sets #13098

Closed
pes10k opened this issue Dec 8, 2020 · 1 comment
Closed

Disable or remove first-party sets #13098

pes10k opened this issue Dec 8, 2020 · 1 comment
Assignees
@mkarolin
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. privacy/chromium-redqueen Work to remove or improve privacy-harming "features" added in Chromium. privacy QA/No release-notes/include
Milestone
1.25.x - Release

Comments

@pes10k
Copy link
Contributor

pes10k commented Dec 8, 2020 •
edited
Loading

Upstream is enabling ways for different sites to declare themselves to be treated as if they were the same first party (though what that means differs in different areas).

We should disable all first-party set behavior for the time being, since its not standardized, well understood, and breaks privacy boundaries in the platform.

re @mkarolin

I am not seeing any flags around it, so we'd probably have to override NetworkService::SetPreloadedFirstPartySets.
@pes10k pes10k added privacy OS/Android Fixes related to Android browser functionality privacy/chromium-redqueen Work to remove or improve privacy-harming "features" added in Chromium. OS/Desktop labels Dec 8, 2020
@pes10k pes10k added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 5, 2021
mkarolin added a commit to brave/brave-core that referenced this issue Apr 7, 2021
@mkarolin
Disables FirstPartySet feature.
fc806dd 
Also disables FirstPartySet component in component updater.

Fixes brave/brave-browser#13098
mariospr pushed a commit to brave/brave-core that referenced this issue Apr 9, 2021
@mkarolin @mariospr
Disables FirstPartySet feature.
93efdc6 
Also disables FirstPartySet component in component updater.

Fixes brave/brave-browser#13098
mariospr pushed a commit to brave/brave-core that referenced this issue Apr 9, 2021
@mkarolin @mariospr
Disables FirstPartySet feature.
8aee100 
Also disables FirstPartySet component in component updater.

Fixes brave/brave-browser#13098
mkarolin added a commit to brave/brave-core that referenced this issue Apr 16, 2021
@mkarolin
Disables FirstPartySet feature.
c33119d 
Also disables FirstPartySet component in component updater.

Fixes brave/brave-browser#13098
mariospr pushed a commit to brave/brave-core that referenced this issue Apr 20, 2021
@mkarolin @mariospr
Disables FirstPartySet feature.
c6379a5 
Also disables FirstPartySet component in component updater.

Fixes brave/brave-browser#13098
mkarolin added a commit to brave/brave-core that referenced this issue Apr 21, 2021
@mkarolin
Disables FirstPartySet feature.
96ab432 
Also disables FirstPartySet component in component updater.

Fixes brave/brave-browser#13098
mkarolin added a commit to brave/brave-core that referenced this issue Apr 23, 2021
@mkarolin
Disables FirstPartySet feature.
28c874f 
Also disables FirstPartySet component in component updater.

Fixes brave/brave-browser#13098
mkarolin added a commit to brave/brave-core that referenced this issue Apr 27, 2021
@mkarolin
Disables FirstPartySet feature.
0e6665e 
Also disables FirstPartySet component in component updater.

Fixes brave/brave-browser#13098
mkarolin added a commit to brave/brave-core that referenced this issue Apr 30, 2021
@mkarolin
Disables FirstPartySet feature.
bd64f31 
Also disables FirstPartySet component in component updater.

Fixes brave/brave-browser#13098
mkarolin added a commit to brave/brave-core that referenced this issue May 5, 2021
@mkarolin
Disables FirstPartySet feature.
47ad430 
Also disables FirstPartySet component in component updater.

Fixes brave/brave-browser#13098
@mkarolin mkarolin added this to the 1.26.x - Nightly milestone May 7, 2021
@mkarolin mkarolin mentioned this issue May 7, 2021
Merged
24 tasks
@mkarolin
Copy link
Contributor

@pes10k I marked this as QA/No. If you have a way for QA to test, please, modify to Yes and provide the steps.

@kjozwiak kjozwiak removed this from the 1.26.x - Nightly milestone May 19, 2021
@kjozwiak kjozwiak added this to the 1.25.x - Beta milestone May 19, 2021
@LaurenWags LaurenWags mentioned this issue May 26, 2021
Closed
This was referenced May 27, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. privacy/chromium-redqueen Work to remove or improve privacy-harming "features" added in Chromium. privacy QA/No release-notes/include
Projects
None yet
Milestone
1.25.x - Release
Development

No branches or pull requests
3 participants
@pes10k @kjozwiak @mkarolin