Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error with the context menu in the bookmarks bar (german language) #12844

Closed
bastele7 opened this issue Nov 22, 2020 · 4 comments · Fixed by brave/brave-core#7232
Closed

Error with the context menu in the bookmarks bar (german language) #12844

bastele7 opened this issue Nov 22, 2020 · 4 comments · Fixed by brave/brave-core#7232
Assignees
@mkarolin
Labels
l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.17.x - Release #3

Comments

@bastele7
Copy link

When I right-click on a folder in the bookmarks, I get an error in the context menu. This does not happen when I click on a single bookmark (see pictures) or if i change the UI-language to english or french.

The problem exists since I upgraded to the new Brave 1.17.73.

Screenshot: Bookmark folder
https://aws1.discourse-cdn.com/brave/original/3X/2/7/27914a04473a605103895eecb278411f266977dd.png

Screenshot: Single bookmark
https://aws1.discourse-cdn.com/brave/original/3X/2/d/2dbdeaa06bcb2ecab69b8ee4ccca475efc941e61.png
@rebron rebron added l10n priority/P2 A bad problem. We might uplift this to the next planned release. labels Nov 23, 2020
@rebron
Copy link
Collaborator

rebron commented Nov 23, 2020

cc: @mkarolin @simonhong Looks like in the first screen shot for DE we're missing Open all in Private Window and all the Open strings aren't locallized.

mkarolin added a commit to brave/brave-core that referenced this issue Nov 23, 2020
@mkarolin
Fixes an error in generated_resources_de.xtb.
98042f1 
Fixes brave/brave-browser#12844
@mkarolin mkarolin self-assigned this Nov 23, 2020
@mkarolin mkarolin mentioned this issue Nov 23, 2020
Merged
23 tasks
@mkarolin
Copy link
Contributor

@rebron fixes the problem with the missing context menu item.

The first two Open strings in the context menu have not been localized yet.

@mkarolin mkarolin added this to the 1.19.x - Nightly milestone Nov 24, 2020
This was referenced Nov 24, 2020
Merged
Merged
@kjozwiak kjozwiak mentioned this issue Nov 27, 2020
Closed
3 tasks
@bastele7
Copy link
Author

bastele7 commented Dec 1, 2020 •
edited
Loading

@rebron: Thanks for fixing this issue. Now the translation is missing at this menue (was translated at version 1.16.76)
#12904

@bastele7 bastele7 mentioned this issue Dec 1, 2020
Closed
This was referenced Dec 3, 2020
Closed
Closed
Closed
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Dec 3, 2020 •
edited by GeetaSarvadnya
Loading

Verification PASSED on macOS x64 10.15.7 using the following build:

Brave | 1.17.75 Chromium: 87.0.4280.88 (Official Build) (x86_64)
-- | --
Revision | 89e2380a3e36c3464b5dd1302349b1382549290d-refs/branch-heads/4280@{#1761}
OS | macOS Version 10.15.7 (Build 19H15)

Reproduced the original issue described via #12844 using 1.17.73:

Single Bookmark Bookmark Folder
1 17 73 single bookmark 1 17 73 multiple bookmarks

Confirmed translation is fixed on 1.17.75:

Single Bookmark Bookmark Folder
1 17 75 single bookmark 1 17 75 multiple bookmarks

Reproduced issue from #12904 as per screenshots above.

Verification passed on

Brave 1.17.75 Chromium: 87.0.4280.88 (Official Build) (64-bit)
Revision 89e2380a3e36c3464b5dd1302349b1382549290d-refs/branch-heads/4280@{#1761}
OS Ubuntu 18.04 LTS

Reproduced the original issue described via #12844 using 1.17.73:

Single Bookmark Bookmark Folder
image image

Verified fixed on 1.17.75:

Single Bookmark Bookmark Folder
image image

Encountered #12904 for missing translations

Verification passed on


Brave | 1.17.75 Chromium: 87.0.4280.88 (Offizieller Build) (64-Bit)
-- | --
Überarbeitung | 89e2380a3e36c3464b5dd1302349b1382549290d-refs/branch-heads/4280@{#1761}
Betriebssystem | Windows 10 OS Version 2004 (Build 19041.630)
  • Verified the description from the issue
Single Bookmark Bookmark Folder
image image

@mkarolin mkarolin mentioned this issue Dec 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.17.x - Release #3
Development

Successfully merging a pull request may close this issue.

Fixes an error in generated_resources_de.xtb. brave/brave-core
7 participants
@kjozwiak @rebron @LaurenWags @btlechowski @GeetaSarvadnya @mkarolin @bastele7