Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Uphold Equities Card #12276

Closed
mandar-brave opened this issue Oct 22, 2020 · 1 comment · Fixed by brave/brave-core#6951
Closed

Add Uphold Equities Card #12276

mandar-brave opened this issue Oct 22, 2020 · 1 comment · Fixed by brave/brave-core#6951

Comments

@mandar-brave
Copy link

Add the Uphold Equities Card.
Here the card design

image

Link: https://uphold.com/en/buy-fractional-shares/brave

Lets make it a priority to get this shipped.
@NejcZdovc @jenn-rhim

@LaurenWags
Copy link
Member

LaurenWags commented Nov 6, 2020

Verified passed with

Brave	1.17.62 Chromium: 86.0.4240.185 (Official Build) dev (x86_64)
Revision	37e6f852ed18086458552039ad26421aa9fc7acc-refs/branch-heads/4240@{#1377}
OS	macOS Version 10.14.6 (Build 18G6032)

Verified tests performed under brave/brave-core#6982 (comment)

US (no promo) KY (has promo)
US KY

Verification passed on

Brave 1.17.63 Chromium: 87.0.4280.49 (Official Build) dev (64-bit)
Revision f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
OS Ubuntu 18.04 LTS
  • Verified that the promotion is shown for the following: NZ, ER, MH, PG
  • ensured that the equities uphold card wasn't being displayed when using US (United States), PL (Poland) & DE (Germany)
  • ensured that the equities uphold card is visible when refreshing/re-opening brave://rewards
  • ensured that the equities uphold card is visible after restarting Brave several times
  • ensured that clicking on X closes the promo and ensured that it's never visible again (refreshing/re-loading/restarting)
  • ensured that clicking on the card opens a new tab and loads the following:

Verification passed on

  • Verified that the promotion is shown for the following: NZ, ZW, CO
  • ensured that the equities uphold card wasn't being displayed when using US (United States), PL (Poland) & FR (France)
  • ensured that the equities uphold card is visible when refreshing/re-opening brave://rewards
  • ensured that the equities uphold card is visible after restarting Brave several times
  • ensured that clicking on X closes the promo and ensured that it's never visible again (refreshing/re-loading/restarting)
  • ensured that clicking on the card opens a new tab and loads the following:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants