Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navigator.userAgent farbling not applied in workers #12230

Closed
pilgrim-brave opened this issue Oct 20, 2020 · 3 comments · Fixed by brave/brave-core#6906
Closed

navigator.userAgent farbling not applied in workers #12230

pilgrim-brave opened this issue Oct 20, 2020 · 3 comments · Fixed by brave/brave-core#6906

Comments

@pilgrim-brave
Copy link

image

@GeetaSarvadnya
Copy link

@pilgrim-brave Can you please link the test plan?

@pilgrim-brave
Copy link
Author

Test plan:

  1. Visit https://dev-pages.brave.software/farbling.html
  2. In Brave Shields panel, change Fingerprinting to "Allow all"
  3. Click 'Generate fingerprints'
  4. In 'User Agent' row, all columns should show the same hash value. Note this hash value for later step.
  5. In Brave Shields panel, change Fingerprinting to "Blocked (strict)"
  6. Refresh page
  7. Click 'Generate fingerprints'
  8. In 'User Agent' row, all columns should show the same hash value. This hash value should be different than the hash value in step 4.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 8, 2020

Verification passed on


Brave | 1.18.69 Chromium: 87.0.4280.88 (Official Build) (64-bit)
-- | --
Revision | 89e2380a3e36c3464b5dd1302349b1382549290d-refs/branch-heads/4280@{#1761}
OS | Windows 10 OS Version 2004 (Build 19041.630)

  • Verified the test plan from navigator.userAgent farbling not applied in workers #12230 (comment)
  • Verified that User-Agent row, all columns have the same hash value when Fingerprinting value is allowed in the shield
    image
  • Verified that User-Agent row, all columns have the same hash value but different than the above step when Fingerprinting value is blocked and strict in the shield
    image

Verification passed on

Brave 1.18.70 Chromium: 87.0.4280.101 (Official Build) (64-bit)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS Ubuntu 18.04 LTS
  • Verified the test plan from navigator.userAgent farbling not applied in workers #12230 (comment)
  • Verified that User-Agent row, all columns have the same hash value when Fingerprinting value is allowed in the shield
    image
  • Verified that User-Agent row, all columns have the same hash value but different than the above step when Fingerprinting value is blocked and strict in the shield
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment