Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Desktop] re-enabling Rewards from panel doesn't work #11038

Closed
LaurenWags opened this issue Jul 31, 2020 · 3 comments · Fixed by brave/brave-core#6321
Closed

[Desktop] re-enabling Rewards from panel doesn't work #11038

LaurenWags opened this issue Jul 31, 2020 · 3 comments · Fixed by brave/brave-core#6321
Assignees
@NejcZdovc
Labels
feature/rewards OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes regression release/blocking release-notes/exclude
Milestone
1.12.x - Release #1

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Jul 31, 2020 •
edited
Loading

Description

Found while testing #9526

If you try to re-enable rewards from the panel it looks like it worked (panel displays correctly), but if you go to brave://rewards page you can see that Rewards are still toggled off. Additionally, BAT Ads Service and BAT Ledger Service are not running in task manager.

This does not reproduce on 1.11.104 current release version.

Steps to Reproduce

  1. Clean profile 1.12.x, open Task Manager. See that BAT Ads and Ledger services are not running.
  2. Enable Rewards (I did this from panel). See BAT Ads and Ledger Services are now running.
  3. Open a new tab, navigate to brave://rewards.
  4. Toggle Rewards off. See BAT Ads and Ledger Services are no longer running.
  5. Close brave://rewards page.
  6. Open panel, get Welcome Back message, click on Enable Brave Rewards button.

Actual result:

Panel looks like it worked, however if you go to brave://rewards page you will see that Rewards are toggled off. Additionally, BAT Ads and Ledger services do not start.

I also saw the below in my logs:

[1270:775:0731/093548.184989:VERBOSE1:rewards_service_impl.cc(435)] Starting ledger process
[1270:775:0731/093548.296659:INFO:database_balance_report.cc(313)] Response is wrong
[1270:775:0731/093548.296735:ERROR:validation_errors.cc(76)] Invalid message: VALIDATION_ERROR_UNEXPECTED_NULL_POINTER (null field 2)
[0731/093548.301015:WARNING:process_memory_mac.cc(93)] mach_vm_read(0x7ffeebcc4000, 0x2000): (os/kern) invalid address (1)
[1270:37379:0731/093548.396972:ERROR:browser_child_process_host_impl.cc(726)] Terminating child process for bad message: Received bad user message: Validation failed for bat_ledger.mojom.BatLedger response [VALIDATION_ERROR_UNEXPECTED_NULL_POINTER (null field 2)]
[1270:775:0731/093548.397045:VERBOSE1:rewards_service_impl.cc(395)] Rewards not enabled

Expected result:

Rewards should be enabled fully.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.12.105 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no for 1.11.x, yes for 1.12.x rc
  • Can you reproduce this issue with the beta channel? yes for 1.13.x
  • Can you reproduce this issue with the nightly channel? yes for 1.14.x

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @rebron @NejcZdovc @brave/legacy_qa
@LaurenWags LaurenWags mentioned this issue Jul 31, 2020
Closed
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 31, 2020 •
edited by btlechowski
Loading

Reproduced in windows 10 x64 - 1.12.105

One more scenario in which Brave Rewards switch in brave://rewards settings can't be disabled twice. STR is as below:

  1. Clean profile 1.12.105
  2. Enable rewards from BR panel
  3. Disable rewards in the settings page (1st time)
  4. Enable the rewards from BR panel ( it doesn't enable rewards in the settings page @LaurenWags logged above)
  5. Enable rewards from the settings page
  6. Disable rewards from settings page (2nd time) -----> Unable to turnoff/disable the Brave Rewards switch

Reproduced on Ubuntu 18.04

Brave 1.12.105 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS Ubuntu 18.04 LTS

@NejcZdovc NejcZdovc added this to the 1.12.x - Release milestone Jul 31, 2020
@NejcZdovc NejcZdovc self-assigned this Jul 31, 2020
@LaurenWags
Copy link
Member Author

After discussing with @NejcZdovc here's a related scenario that should also be checked once this issue is fixed:

  • Enable Rewards
  • Toggle ads off and back on
  • Toggle rewards off and back on (wait for all "normal" log messages to be done, pub list, etc)
  • Reset Rewards
    --> panel is not showing correctly. After fix confirm panel displays as expected.
Brave | 1.12.105 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | macOS Version 10.14.6 (Build 18G3020)

@NejcZdovc NejcZdovc mentioned this issue Aug 3, 2020
Merged
32 tasks
NejcZdovc added a commit to brave/brave-core that referenced this issue Aug 4, 2020
@NejcZdovc
Adds initialized to panel flow
dd5c0ba 
Resolves brave/brave-browser#11038
NejcZdovc added a commit to brave/brave-core that referenced this issue Aug 4, 2020
@NejcZdovc
Adds initialized to panel flow
dae1ca4 
Resolves brave/brave-browser#11038
@NejcZdovc NejcZdovc mentioned this issue Aug 4, 2020
Merged
4 tasks
@NejcZdovc NejcZdovc mentioned this issue Aug 4, 2020
Merged
4 tasks
NejcZdovc added a commit to brave/brave-core that referenced this issue Aug 4, 2020
@NejcZdovc
Adds initialized to panel flow
0d62687 
Resolves brave/brave-browser#11038
NejcZdovc added a commit to brave/brave-core that referenced this issue Aug 4, 2020
@NejcZdovc
Adds initialized to panel flow
4947f3a 
Resolves brave/brave-browser#11038
@LaurenWags
Copy link
Member Author

LaurenWags commented Aug 6, 2020 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave | 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | macOS Version 10.14.6 (Build 18G3020)

Verification passed on

Brave 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS Ubuntu 18.04 LTS

Verification passed on

Brave | 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | Windows 10 OS Version 1903 (Build 18362.959)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes regression release/blocking release-notes/exclude
Projects
None yet
Milestone
1.12.x - Release #1
Development

Successfully merging a pull request may close this issue.

Adds initialized to panel and NTP flow brave/brave-core
4 participants
@NejcZdovc @LaurenWags @btlechowski @GeetaSarvadnya