Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Verify Wallet drop down not displayed when in Pending state - follow up to 10023 #10995

Closed
LaurenWags opened this issue Jul 29, 2020 · 2 comments · Fixed by brave/brave-core#6252 or brave/brave-core#6263

Comments

@LaurenWags
Copy link
Member

Description

Follow up to #10023
Found while testing brave/brave-core#6140

When in Pending state the wallet drop down should be shown but it is not.

Steps to Reproduce

  1. Clean profile, staging, enable Rewards, claim grant
  2. Click on Verify wallet
  3. Create a new account (email, password, etc)
  4. You're momentarily taken to brave://rewards and then directed back to uphold.
  5. Go to brave://rewards, click on Verify Wallet

Actual result:

No drop down shown

Expected result:

Drop down should be shown reflecting "Pending" state

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.13.51 Chromium: 84.0.4147.105 (Official Build) nightly (64-bit)
Revision a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @NejcZdovc

@LaurenWags LaurenWags changed the title [Desktop] Verify Wallet drop down not displayed when in Pending state [Desktop] Verify Wallet drop down not displayed when in Pending state - follow up to 10023 Jul 29, 2020
@NejcZdovc NejcZdovc self-assigned this Jul 29, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Jul 29, 2020
@NejcZdovc NejcZdovc added this to the 1.14.x - Nightly milestone Jul 29, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Jul 31, 2020
@LaurenWags
Copy link
Member Author

Marking as QA/Blocked as this needs a new 1.12.x build to test

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 5, 2020

Verification passed on


Brave | 1.12.107 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | Windows 10 OS Version 1903 (Build 18362.959)



Verification passed on

Brave 1.12.107 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#6252

  • Verified pending popup on brave://rewards
    image

  • Verified pending popup on Rewards Panel
    image


Verified passed with

Brave | 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-08-07 at 2 28 32 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment