Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Repurpose the global autoplay content setting so that it allows overriding the Chrome policy #10807

Closed
pes10k opened this issue Jul 19, 2020 · 10 comments · Fixed by brave/brave-core#6130

Comments

@pes10k
Copy link
Contributor

pes10k commented Jul 19, 2020

Background: Previously Brave had its own autoplay system, based on a list, b/c Chrome's autoplay policy was crummy. Now Chrome's policy is a lot better than it was, so Brave has removed its custom system and just falls back on Chrome's (#9597, brave/brave-core#5970, etc).

However, we still have the global "autoplay" content setting as a vestigial hold over from the previous system. We should use it to allow users to still disable autoplay, if they don't like Chrome's new-and-improved system.

@pes10k
Copy link
Contributor Author

pes10k commented Jul 19, 2020

If we don't do this, we should remove the autoplay content setting, to avoid confusion

@pes10k
Copy link
Contributor Author

pes10k commented Jul 19, 2020

Screen Shot 2020-07-18 at 8 13 25 PM

FWIW, this is the autoplay content setting referred to above

@timkgh
Copy link

timkgh commented Jul 19, 2020

Always block is very valuable. Please make it work instead of removing it.

@pes10k
Copy link
Contributor Author

pes10k commented Jul 19, 2020

Thanks @timkgh. Its useful for us to get a sense of this, so we know what to prioritize. No promises on a final decision, since theres a lot of high priority things on our plate, but its useful to know that its a feature folks would use

@pes10k pes10k added the feature/global-settings Settings at browser level independent of shields settings label Jul 19, 2020
@pes10k pes10k changed the title [Desktop] Repurpose the autoplay content setting so that it allows overriding the Chrome policy [Desktop] Repurpose the global autoplay content setting so that it allows overriding the Chrome policy Jul 19, 2020
@umbraesoulsbane
Copy link

Just chiming in on this. This is a critical feature for me. Since this became an issue in Brave I have switched to Chrome Edge. I prefer Brave (especially mobile) but the lack of zero autoplay I only use it for a handful of cases.

@bsclifton
Copy link
Member

bsclifton commented Jul 20, 2020

+1 from several users in #9597

Per @darkdh in #9597 (comment)

Just verified

per site autoplay setting works
Screen Shot 2020-07-18 at 21 14 24

global autoplay setting doesn't work
issue tracked here
(#10807)
Screen Shot 2020-07-18 at 21 16 35

@pes10k
Copy link
Contributor Author

pes10k commented Jul 20, 2020

There are three related issues here:

  1. The text incorrect on the global toggle: [Desktop] Description of default setting for autoplay is incorrect (says "ask") #10810
  2. The global setting doesn't seem to apply in most cases, for most users: [Desktop] Repurpose the global autoplay content setting so that it allows overriding the Chrome policy #10807
  3. For some users / profiles, the site specific setting doesn't work (my profile, for example): Site-specific autoplay settings are not respected for some profiles #10811

@wolfiejunk
Copy link

Agree with others that global autoplay off should be available and easy to access. It is for us a very high value problem and we find ourselves more and more migrating away from Brave. Simply... Global Autoplay Off Yes/No

@btlechowski
Copy link

btlechowski commented Aug 14, 2020

Verification passed on

Brave 1.13.71 Chromium: 84.0.4147.125 (Official Build) dev (64-bit)
Revision d0784639447f2e10d32ebaf9861092b20cfde286-refs/branch-heads/4147@{#1059}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#6130

Autoplay default setting options
Allowed
image
Blocked
image
Verified Polish translation

Autoplay set default block
Video is blocked
image

Autoplay default allow
Video is player
image

Autoplay blocked through the block list
Video is blocked
image


Verified passed with

Brave | 1.13.79 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
-- | --
Revision | 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS | macOS Version 10.14.6 (Build 18G3020)

Verified test plan from brave/brave-core#6130

Autoplay default setting options
Allowed
Allowed

Blocked
Blocked

Autoplay set default = Blocked
Video is blocked
default blocked

Autoplay set default = Allowed
Video plays automatically
default allow

Autoplay blocked on a per site basis
Video is blocked
per site block


Verification passed on

Brave | 1.13.79 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
-- | --
Revision | 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

Autoplay default setting options

  • Verified Autoplay option is "Allowed" when toggle is ON in brave://settings/content/autoplay
    image
  • Verified Autoplay option is "Blocked" when toggle is OFF in brave://settings/content/autoplay
    image

Autoplay set default block

  • Verified video is not autoplay when autoplay option is "Blocked" in brave://settings/content/autoplay
    image

Autoplay default allow

  • Verified video is autoplay when the default option is set to "Allowed"
    image
  • Verified video is not autoplay when cnn.com is added to "Blocked" list through brave://settings/content/siteDetails?site=https%3A%2F%2Fwww.cnet.com
    image

@hennrynusasatria
Copy link

Hi @btlechowski

This Autoplay blocker does not work on this site:

https://inet.detik.com/security/d-5149755/sering-dibobol-ini-pembelaan-whatsapp?tag_from=wp_beritautama

I have turned the Global Autoplay Content Setting to "Blocked", but the video keeps autoplaying on the above site, can you help to check?

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants