-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial pkpass support #327
base: master
Are you sure you want to change the base?
Conversation
I've opted for using a new EXTRAS database field to store this all in, because putting all of this data in the note doesn't seem doable. See #309 (comment) for how this looks to the end-user. |
While not perfect, it does enough to be useable. I guess I consider this to be "ready for review" now, @brarcher. It's a rather huge change, so to explain the architecture a bit:
Some notes:
|
I couldn't resist and I'm sure the legal worries of #303 don't apply when they literally put the icon in the file that's provided. |
I suppose that the name of the app should be changed, as boarding cards or event tickets are not loyalty cards. I am going to open a new issue about that. |
I personally would keep the app name the same and just write in the description it also supports event tickets and stuff. |
This will probably take a bit longer to make completely useful, but this at least does the initial parsing. Marking this WIP just because I believe in sharing progress to allow for early feedback.
When this is done, it will fix #309.
TODO:
This change is