Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change keyword to findplus #407

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

dezza
Copy link

@dezza dezza commented Mar 27, 2024

The current situation that find is a keyword is too common.

findplus is at least less likely to clash with searches.

Fixes

Changes Proposed in this Pull Request:

  • Change keyword to findplus

Additional Comments and Documentation:

The current situation that `find` is a keyword is too common.

Findplus is at least less likely to clash with searches.
Copy link
Contributor

@pzhlkj6612 pzhlkj6612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR!

Using "find+" looks also good to me.

@pzhlkj6612
Copy link
Contributor

@dezza, please check this PR: dezza#1

@dezza
Copy link
Author

dezza commented Apr 20, 2024

Ok I understand now 😂 sorry I was confused I thought it was a thirdparty who opened a PR on my temporary fork! 😂 (I thought this PR was merged already)

Merged.

@dezza
Copy link
Author

dezza commented Aug 24, 2024

Why is this not merged yet? I was just annoyed by this feature again today, I thought this was resolved.

find is an incredibly common word it gets in the way of keyword search if this extension is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants