Use shared_ptr<ofImage> for theme icons #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braitsch
added a commit
that referenced
this pull request
Mar 21, 2016
Use shared_ptr<ofImage> for theme icons
|
This has been on my todo list, thanks for addressing it. I think this implementation is fine for now. |
|
Thanks! |
|
No problem, thanks for your help! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got tired of seeing tons of duplicate textures in the OpenGL profiler and figured they could get shared across components. Not sure if this implementation is the best route, but it seems to work?