Benchmark for cellfinder workflow with CLI arguments#24
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
==========================================
+ Coverage 92.56% 92.80% +0.23%
==========================================
Files 2 2
Lines 121 125 +4
==========================================
+ Hits 112 116 +4
Misses 9 9
☔ View full report in Codecov by Sentry. |
00970cc to
76352ac
Compare
alessandrofelder
left a comment
There was a problem hiding this comment.
Tiny comment that I am not sure about.
Otherwise LGTM 🚀
asv.conf.json
Outdated
|
|
||
| // List of branches to benchmark. If not provided, defaults to "master" | ||
| // (for git) or "default" (for mercurial). | ||
| "branches": ["smg/cellfinder-workflow"], // for git |
There was a problem hiding this comment.
Is this right? (It's a different name to the branch of the PR and I had to change it to run it locally?)
There was a problem hiding this comment.
yes sorry, I think that came about from the rebasing and merging of conflicts 🤔
it should have been smg/cellfinder-workflow-cli-w-tests but now that is merged main should work
actually it won't work with main just yet, since I refactored the workflows in this PR 😓
|
(Also, remember to rebase I guess @sfmig ?) |
Adds
asvbenchmarks to time the cellfinder workflows defined in PR #23.We benchmark the full workflow and its individual steps (reading, detecting cells and saving results to file).
This PR also includes some refactoring changes to the cellfinder workflows, to allow us to split the setup steps into data downloading and other steps. This way we can download the data only once for all the repeats of a benchmark.
Would need rebasing after PR #23 is squash-and-merged
To run the benchmarks, run
asv runfrom the directory whereasv.conf.json