Closed
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 1 2 +1
Lines 5 63 +58
=====================================
- Misses 5 63 +58
☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
superseded by #94 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
asvbenchmarks to time the workflow defined in #15The benchmarks time the full workflow and also its individual steps. They are grouped under classes: the
time_methods of one class share setup and teardown functions and other benchmark attributes.Some points where feedback is welcome:
I am not sure we really need a teardown function after each benchmark.... 🤔 (right now it just removes the cellfinder-benchmark temporary directory)
I was looking for a way of defining
setupfunctions for each benchmark abstracting the common bits to avoid too much repetition. I ended up with this approach that uses the@classmethoddecorator, but not sure it is the best way (I'm not super familiar with OOP). I also considered setup_cache but I think it serves a different purpose (mainly running computationally intense setup methods only once). I basically wanted to do what it says in the docs:but not sure how. Any thoughts welcome!
Should we have the benchmarks in a different repo? I know we want to minimise number so maybe here they are fine. I don't see strong arguments for or against apart from that one.
Is it repetitive to benchmark the whole workflow and also its parts? Should we just benchmark the whole, and rely on profiling when issues are found?
the main advantage of
asvseems its ability to identify performance regressions across commits....but here the commits we track against would be those from the workflows repo. I understand it would be more interesting for us to track performance regressions for thecellfinder-corecommits right? I think it could be done but we may need to rethink the structure.replace "cellfinder-core" with "cellfinder"