Skip to content

Conversation

@usyless
Copy link
Contributor

@usyless usyless commented Oct 21, 2025

register_command with dpp::task was not working for me on windows with msvc, this fixes that, and it makes sure to keep register_command working for non coroutines.

I have not tested the changes on anything other than windows, therefore I'm unsure if im sacraficing other platforms.

Also I'm not sure if this is the ideal fix, however it does also let clangd correctly determine the function in use when ctrl+click'ing the register_command, as previously it would just use the non-coro one for all usages of register_command for me. (It is inspired by how dpp::cluster::start_timer works, which works correctly for me)

As of the latest commit it now only allows void or dpp::task function return signatures as well.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@netlify
Copy link

netlify bot commented Oct 21, 2025

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 3e21b57
🔍 Latest deploy log https://app.netlify.com/projects/dpp-dev/deploys/68f84712bce9650008e5f83f
😎 Deploy Preview https://deploy-preview-1504--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Oct 21, 2025
@Mishura4
Copy link
Member

Mishura4 commented Nov 4, 2025

Tested on WSL g++ 14, clang++ 21, confirmed to work, merging after CI!

@Mishura4
Copy link
Member

Mishura4 commented Nov 4, 2025

O, CI is already finished

@Mishura4 Mishura4 merged commit e84c66d into brainboxdotcc:dev Nov 4, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code Improvements or additions to code. documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants