fix(ci): impact workflow permission — issues:write → pull-requests:write - #816
Merged
Conversation
…requests:write The impact analysis posts PR comments via the Issues API, which accepts either issues:write or pull-requests:write. Using pull-requests:write is least-privilege since this workflow only operates on PRs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
🔒 Security Review🔒 Security review: 1 info.
Automated security review — informational only. |
Contributor
🛫 PR Readiness Check
|
| Status | Check | Details |
|---|---|---|
| ✅ | Single commit | 1 commit — clean history |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | No source files changed — changeset not required |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | No Copilot review threads |
| ❌ | CI passing | 14 check(s) still running |
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
Contributor
🏗️ Architectural Review
Automated architectural review — informational only. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the squad-impact GitHub Actions workflow token permissions so the impact analysis job can post/update its PR comment, unblocking CI for PRs that rely on the impact report.
Changes:
- Update workflow
permissionsto usepull-requests: write(instead ofissues: write/pull-requests: read) for PR comment posting.
tamirdresher
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line fix: the impact analysis workflow needs \pull-requests: write\ (not \issues: write) to post PR comments. This was missed when #786 was decontaminated.
Unblocks CI for #813, #800, #768.