test(gh-aw): enforce dispatcher-first install order

[bradygaster]

Summary

• correct the stale install-order regression assertion to require dispatcher, implementation worker, then reviewer
• verify all three workflow entries are present
• assert the current dispatcher-first dependency-discovery explanation

Validation

• test/gh-aw-implement-workflow.test.ts: 14 passed with cached Vitest 4.1.9
• targeted ESLint passed with the cached ESLint 10.8.1 TypeScript test configuration
• dispatcher/worker mutation: focused assertion failed as expected
• worker/reviewer mutation: focused assertion failed as expected
• git diff --check passed

The mandated npm proxy does not provide locked vitest@4.1.11; manifests and lockfiles are unchanged.

Working as FIDO (Quality Owner).

Closes #1878

[github-actions]

🟢 Impact Analysis — PR #1879

Risk tier: 🟢 LOW

📊 Summary

Metric	Count
Files changed	1
Files added	0
Files modified	1
Files deleted	0
Modules touched	1

🎯 Risk Factors

• 1 files changed (≤5 → LOW)
• 1 module(s) touched (≤1 → LOW)

📦 Modules Affected

tests (1 file)

• test/gh-aw-implement-workflow.test.ts

---

This report is generated automatically for every PR. See #733 for details.

[github-actions]

🛫 PR Readiness Check

ℹ️ This comment updates on each push. Last checked: commit ade7250

PR Scope: 🔧 Infrastructure

⚠️ 3 item(s) to address before review

Status	Check	Details
❌	Single commit	2 commits — consider squashing before review
✅	Not in draft	Ready for review
❌	Branch up to date	dev is 2 commit(s) ahead — rebase recommended
❌	Copilot review	No Copilot review yet — it may still be processing
✅	Changeset present	No source files changed — changeset not required
✅	Scope clean	No .squad/ or docs/proposals/ files
✅	No merge conflicts	No merge conflicts
✅	Copilot threads resolved	0 active Copilot thread(s) resolved (1 outdated skipped)
✅	CI passing	All checks passing

Files Changed (1 file, +26 −6)

File	+/−
test/gh-aw-implement-workflow.test.ts	+26 −6

Total: +26 −6

---

This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.

[Copilot]

🟡 Changes recommended

The updated test can still pass by matching the three workflow references from different occurrences in the guide, so it doesn’t strictly guarantee a single gh aw add snippet contains all three entries in the correct order.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates the gh-aw workflow guide contract test to reflect the dispatcher-first install order introduced in prior rollout work, ensuring documentation and test expectations align with current dependency-discovery behavior.

Changes:

• Updates the install-order assertions to require dispatcher → implementation worker → reviewer.
• Verifies all three workflow entries are present in the guide.
• Replaces the stale worker-first prose assertion with a dispatcher-first dependency-discovery explanation match.

File summaries

File	Description
test/gh-aw-implement-workflow.test.ts	Adjusts documentation contract assertions for dispatcher-first install order and updated explanatory prose.

Review details

• Files reviewed: 1/1 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟢 Approval recommended

The changes are confined to test expectations and correctly enforce the documented dispatcher-first install contract with a mutation-proof negative check.

Review details

• Files reviewed: 1/1 changed files
• Comments generated: 0 new
• Review effort level: Lite