test(workflows): derive next hints from ontology - #1873
Merged
Conversation
Closes #1780 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
🟢 Impact Analysis — PR #1873Risk tier: 🟢 LOW 📊 Summary
🎯 Risk Factors
📦 Modules Affectedtests (1 file)
This report is generated automatically for every PR. See #733 for details. |
Contributor
🛫 PR Readiness Check
PR Scope: 🔧 Infrastructure
|
| Status | Check | Details |
|---|---|---|
| ❌ | Single commit | 2 commits — consider squashing before review |
| ✅ | Not in draft | Ready for review |
| ❌ | Branch up to date | dev is 2 commit(s) ahead — rebase recommended |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | No source files changed — changeset not required |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | 0 active Copilot thread(s) resolved (1 outdated skipped) |
| ❌ | CI passing | 1 check(s) failing: test |
Files Changed (1 file, +271 −19)
| File | +/− |
|---|---|
test/gh-aw-plan-lifecycle.test.ts |
+271 −19 |
Total: +271 −19
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is test-only and correctly strengthens drift detection; the only feedback is a small parser-brittleness improvement (optional) around fenced code blocks.
Pull request overview
Updates the planning lifecycle anti-drift tests to derive /squad plan … next= hint expectations directly from the authoritative planning ontology transition ordering, closing the gap where ontology drift could preserve a few pinned inequalities while silently desyncing workflows/squad.md.
Changes:
- Parse the ontology “State Transition Table” into a validated, linear transition sequence and derive the planning command order from
triggered_bytransitions. - Derive expected
next=hints from the ontology order and compare them to the hints parsed from each workflow skill’s “Update Lifecycle” step. - Add mutation-style tests to ensure reordered ontology transitions (while preserving the original inequalities) fail unless the workflow hints are updated accordingly.
File summaries
| File | Description |
|---|---|
| test/gh-aw-plan-lifecycle.test.ts | Reworks #1758.3 to compute expected planning next-hints from ontology transitions and adds fail-closed validation + mutation tests. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Closes #1780 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 94cbb3a1-5c30-46a4-8bab-e075e1c1ff1c
5 tasks
bradygaster
added a commit
that referenced
this pull request
Aug 25, 2026
…ows (#1886) - Pin gh-aw to v0.86.2 in the \ est\ job so compiler version is deterministic across runs (was unpinned with \gh extension install\). - Add \gh-aw-compile\ job that strict-compiles squad, squad-implement-worker, squad-review, and squad-deps-worker on every PR and push. Failures accumulate before exit so all four results are visible in one run. A compiler that exits 0 without emitting a lock file also fails the gate (silent-success is a gate gap). Same v0.86.2 pin used in both jobs. Required-check setup (external, cannot be enforced from repo code): Enable ruleset 12703724, add refs/heads/dev and refs/heads/main, require \Squad CI / gh-aw strict compile\ and \Squad CI / test\. Addresses: gh-aw version non-determinism and the missing dedicated compile gate that allowed #1873 and #1874 to merge with failing checks. Co-authored-by: brady gaster <bradygaster@github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
next=hint sequence from ontologytriggered_bytransitionsValidation
git diff --check: passedvitest@4.1.11; manifests and lockfile were left unchangedgh aw compile workflows\\squad.md --strictcannot resolve sibling dispatch workflows from this source-layout repository (expects.github/workflows)Working as Procedures (Prompt Engineer).
Closes #1780