Skip to content

Guard symlink test for Windows/restricted environments #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bradygaster merged 2 commits into from
Jun 30, 2026
Merged

Guard symlink test for Windows/restricted environments #1418

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5763bc8
fix(test): guard observer symlink setup
bradygaster Jun 30, 2026
f8553a0
Address symlink test review feedback
bradygaster Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions test/squad-observer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,31 @@ function cleanupTmpDir() {
}
}

function isUnsupportedSymlinkError(error: unknown): boolean {
const code = typeof error === 'object' && error !== null && 'code' in error
? (error as NodeJS.ErrnoException).code
: undefined;
return code === 'EPERM' || code === 'EACCES' || code === 'ENOSYS';
}

function canCreateSymlink(): boolean {
const probeDir = fs.mkdtempSync(path.join(os.tmpdir(), 'squad-observer-symlink-probe-'));
try {
const targetDir = path.join(probeDir, 'target');
const symlinkPath = path.join(probeDir, 'link');
fs.mkdirSync(targetDir);
fs.symlinkSync(targetDir, symlinkPath, 'dir');
return true;
} catch (error) {
if (isUnsupportedSymlinkError(error)) return false;
throw error;
} finally {
fs.rmSync(probeDir, { recursive: true, force: true });
}
}

const symlinkSupported = canCreateSymlink();

// ---------------------------------------------------------------------------
// classifyFile tests
// ---------------------------------------------------------------------------
Expand Down Expand Up @@ -206,11 +231,12 @@ describe('SquadObserver', () => {
expect(spans.some(s => s.name === 'squad.observer.file_change')).toBe(false);
});

it('skips symlinked directories when resolving root directory events', async () => {
(symlinkSupported ? it : it.skip)('skips symlinked directories when resolving root directory events', async () => {
const outsideDir = fs.mkdtempSync(path.join(os.tmpdir(), 'squad-observer-outside-'));
try {
fs.writeFileSync(path.join(outsideDir, 'newest.md'), 'outside');
fs.symlinkSync(outsideDir, path.join(squadDir, 'linked-outside'), 'dir');
const symlinkPath = path.join(squadDir, 'linked-outside');
fs.symlinkSync(outsideDir, symlinkPath, 'dir');

const olderFile = path.join(squadDir, 'team.md');
fs.writeFileSync(olderFile, 'inside');
Expand Down