Fix Redis, add Docker compose, show how to setup project in README.md #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a docker-compose.yml file to setup the Redis image in a Docker container among other things.
Closes #55
Adds chained scripts to run the project and shut it down somewhat gracefully by using improved error handling for Redis (ie. once it is disconnected on docker-compose-down). There are 3 reconnect retries then the app is killed.
Also adds scripts for shutting down Redis and removing data from the Docker volumes.
Updated README.md to show the steps of how to setup the project (and link to setup Docker Desktop).
Testing: all app functionality works on localhost.
Haven't updated anything with Repl.it