Push promise handler #34
Conversation
As predicted, I ended up unifying the Headers and Push Promise packing. This is in preparation for reusing the writeResHeaders functionality of sending continuation frames if the headers are too big.
The API uses loopback to the top handler in order to make sure that the resources being pushed are related to the resource being fetched. If the header parameter is nil, we copy the headers from the initiating request. This is mostly a shortcut for the common case where we don't want to specify any new request headers.
…client concurrent streams to 100 and make some code refactoring from DanielMorsing.
* add default priority and dependency for push stream; * add check in processData function for push stream.
| panic("Push called after Handler finished") | ||
| } | ||
| if h == nil { | ||
| h = rws.req.Header |
There was a problem hiding this comment.
I hope I understand this correctly... If the response handler that handles the initial request that comes from the client does a "Set-Cookie", the follow-up (pushed) request won't see the cookie, because the headers are simply copied from the initial request that comes from the client.
Should the cloned header include the cookie that was just set?
|
This repo just moved into the official Go repo. See https://github.com/bradfitz/http2/blob/master/README for the move details. File new bugs at: https://github.com/golang/go/issues/new?title=x/net/http2:+ Closing this PR as we're now using Gerrit for code review. Please file a bug or send the review to Gerrit if this is still relevant. Sorry for how long this languished here. |
Improving DanielMorsing's (#23) push branch: