-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add slack notification on failed integration tests #381
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Hanshal Mehta <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #381 +/- ##
=======================================
Coverage ? 28.13%
=======================================
Files ? 128
Lines ? 11209
Branches ? 0
=======================================
Hits ? 3154
Misses ? 7773
Partials ? 282
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. I left some comments, but reading up on this some more it seems like webhooks are being deprecated no longer recommended for this usecase + we don't have the ability to add them easily on the K8s slack instance.
We can certainly request a webhook from the admins, but it might make more sense to do use the Github integration like this: https://github.com/integrations/slack?tab=readme-ov-file#workflow-notification-filters
That's more flexible since we can subscribe/unsubscribe to notifications in the channel whenever we like.
Signed-off-by: Hanshal Mehta <[email protected]>
Thanks @dave-tucker for the review, I have updated the CI to the official |
Fixes #332
Closes #332
Description
This PR adds the feature to give alerts on slack when the integration tests fails.
TODO
@anfredette , we need to add a Github secret named
SLACK_WEBHOOK_URL
to enable the alerts.