Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add currency class #30

Merged
merged 4 commits into from
Nov 1, 2018
Merged

add currency class #30

merged 4 commits into from
Nov 1, 2018

Conversation

bucko13
Copy link
Contributor

@bucko13 bucko13 commented Oct 31, 2018

Utilities for getting currency descriptors. Extends Amount from hsd to make other currency related utilities available but abstracts out chain specific names.

Includes tests but for "real world" use case, see simple-wallet PR 16

@bucko13
Copy link
Contributor Author

bucko13 commented Oct 31, 2018

@tynes updated to appropriately add flexibility for coins with different base exponents (e.g. 6 for handshake and 8 for bitcoin/cash)

tynes
tynes previously approved these changes Nov 1, 2018
Copy link
Contributor

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@bucko13 bucko13 merged commit e60019b into master Nov 1, 2018
@bucko13 bucko13 deleted the currency branch November 1, 2018 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants