Skip to content

Fix ExampleCommand build break caused by Spectre.Console.Cli API change#47

Merged
boxofyellow merged 1 commit intomainfrom
copilot/fix-example-project-build-break
Apr 9, 2026
Merged

Fix ExampleCommand build break caused by Spectre.Console.Cli API change#47
boxofyellow merged 1 commit intomainfrom
copilot/fix-example-project-build-break

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 9, 2026

AsyncCommand<T>.ExecuteAsync changed signature in a newer version of Spectre.Console.Cli — the override now requires a CancellationToken parameter and is protected rather than public, breaking the Example project build.

Changes

  • Program.cs: Update ExecuteAsync override to match the new signature:

    // Before
    public override async Task<int> ExecuteAsync(CommandContext context, ExampleSettings settings)
    
    // After
    protected override async Task<int> ExecuteAsync(CommandContext context, ExampleSettings settings, CancellationToken cancellationToken)
  • ci.yml: Add a dedicated build step for ConsoleMarkdownRenderer.Example so regressions in the example project are caught by CI going forward.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.46%. Comparing base (41e969d) to head (1bc068b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #47   +/-   ##
=======================================
  Coverage   90.46%   90.46%           
=======================================
  Files          18       18           
  Lines         839      839           
  Branches       86       86           
=======================================
  Hits          759      759           
  Misses         59       59           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@boxofyellow boxofyellow merged commit 02972b0 into main Apr 9, 2026
8 checks passed
@boxofyellow boxofyellow deleted the copilot/fix-example-project-build-break branch April 9, 2026 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants