Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to build on Mac M1 because Cannot download node - 404 | Slack notification not working because using a depreciated api endpoint #883

Closed
wants to merge 6 commits into from

Conversation

kdcyberdude
Copy link

@kdcyberdude kdcyberdude commented Nov 3, 2022

Why the project is not building on Mac M1 - eirslett/frontend-maven-plugin#952 (comment)
Why slack notification is not working - howdyai/botkit#1988

kdcyberdude added 2 commits November 3, 2022 09:16
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


kdcyberdude seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kdcyberdude kdcyberdude changed the title Not able to build on Mac M1 | Cannot download node - 404 Not able to build on Mac M1 because Cannot download node - 404 | Slack notification not working because using a depreciated api endpoint Nov 3, 2022
@aurambaj
Copy link
Collaborator

@kdcyberdude can you accept the license/cla, so i can merge your changes?

@@ -25,7 +25,7 @@ public class SlackClient {

static final String BASE_API_URL = "https://slack.com/api/";
static final String API_USER_LOOKUP_BY_EMAIL = "users.lookupByEmail";
static final String API_IM_OPEN = "im.open";
static final String API_IM_OPEN = "conversation.open";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you mind renaming the constant?

Does the new entry point take the exact same input, I check the doc quickly and it seems to now use "users" field in the payload and not "user"? Have you tried it with that exact code?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revisiting this, it needs converstation"s" and also change the payload, coming up with another PR for this

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aurambaj, I've already signed a CLA agreement months ago but it's still pending with the following reason.

kdcyberdude seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

I suggest you to push the changes yourself. As you mentioned it is needs "conversations" in the API and "users" in the parameters. I had made the changes month ago and tested it already.

One more thing, can you update the docs mentioning the slack notification trigger points. Still I am not able to fully understand when the notification get's triggered if multiple developers are pushing the changes in their respective branch on mojito.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 that's unfortunate, not sure what's happening. I went ahead and commit: 4d205e4 for the slack client fix.

Thanks for following up!

The way we use it is that each developer as it own feature branch. they are independent branches (with their own new/deleted strings) so each developer have their own notifications as described in that doc: https://www.mojito.global//docs/guides/branching/. The string set in Mojito is the union of the string on all branches. Do you use it the same way? What's unclear? are you missing notifications?

@aurambaj
Copy link
Collaborator

aurambaj commented Oct 5, 2024

could not merge at the time CLA, but the content of this PR was eventually added

@aurambaj aurambaj closed this Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants