Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refacto delete screenshot #856

Closed
wants to merge 4 commits into from
Closed

Conversation

aurambaj
Copy link
Collaborator

No description provided.

… that can be parametrized given Actions callback

This way each modal can have its own independent callback (and we don't broadcast).

See how register Async is moved into the childrens.

General thinking, we had:
S1(DS1) -> onDelete() --> DS1.delete --> DS1.success --> A.onDeleteSuccess --> S1.onDeleteSuccess
                                                                           --> S2.onDeleteSuccess
S2(DS1) -> onDelete() --> DS1.delete --> DS1.success --> A.onDeleteSuccess --> S1.onDeleteSuccess
                                                                           --> S2.onDeleteSuccess

we want:

S1(DS1) -> onDelete() --> DS1.delete --> DS1.success --> A1.onDeleteSuccess --> S1.onDeleteSuccess
S2(DS2) -> onDelete() --> DS2.delete --> DS2.success --> A2.onDeleteSuccess --> S2.onDeleteSuccess

--> DS1 must be replaced from singleton to parametrized class with action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants