Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Semantic Pull Request app configuration #780

Merged
merged 2 commits into from
Dec 2, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/semantic.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
titleOnly: true
40 changes: 34 additions & 6 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ This will create your own copy of our repository.
The upstream source is the project under the Box organization on GitHub. To add an upstream source for this project, type:

```
git remote add upstream [email protected]:Box/box-windows-sdk-v2.git
git remote add upstream [email protected]:box/box-windows-sdk-v2.git
```

This will come in useful later.
Expand All @@ -43,15 +43,41 @@ Create a branch with a descriptive name, such as `add-search`.

### Step 5: Push your feature branch to your fork

As you develop code, continue to push code to your remote feature branch. Please make sure to include the issue number you're addressing in your commit message, such as:
We use [semantic-versioning](https://semver.org/) and the [conventional commit message format](https://www.conventionalcommits.org/en/v1.0.0/). Keep a separate feature branch for each issue you want to address. As you develop code, continue to push code to your remote feature branch. Example:

```
git commit -m "Adding search (fixes #123)"
tag: short description

longer description here if necessary.
```

This helps us out by allowing us to track which issue your commit relates to.
The message summary should be a one-sentence description of the change, and it must be 72 characters in length or shorter. For a list of tags, please [click here](https://github.com/commitizen/conventional-commit-types/blob/master/index.json). Note that you must include the `!` for breaking changes (e.g. `feat!: removed old apis`).

Shown below are examples of the release type that will be done based on a commit message.

#### Commit Types

"Semantic versioning" means that changes to the version number of the package (e.g. `3.42.11` to `3.43.0`) are done according to rules that indicate how the change will affect consumers. Read more on the [semver page](https://semver.org/).

The version number is broken into 3 positions — `Major.Minor.Patch`. In semantic release terms, changes to the numbers follow `Breaking.Feature.Fix`. The `release` script parses commit messages and decides what type of release to make based on the types of commits detected since the last release.

Keep a separate feature branch for each issue you want to address.
The rules for commit types are:

- Anything that changes or removes an API, option, or output format is a breaking change denoted by `!`.
- Anything that adds new functionality in a backwards-compatible way is a feature (`feat`). Consumers have to upgrade to the new version to use the feature, but nothing will break if they do so.
- Bugfixes (`fix`) for existing behavior are a patch. Consumers don't have to do anything but upgrade.
- Other prefixes, such as `docs` or `chore`, don't trigger releases and don't appear in the changelog. These tags signal that there are **no external changes to _any_ APIs** (including non-breaking ones).

In most cases, commits will be a `feat` or `fix`. Make sure to include the `!` in the title if there are non-backwards-compatible changes in the commit.

| Commit message | Release type | New version |
| ------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------ | ----------- |
| `feat!: remove old files endpoints` | Major ("breaking") | `X+1.0.0` |
| `feat: add new file upload endpoint` | Minor ("feature") | `X.Y+1.0` |
| `fix: file streaming during download` | Patch ("fix") | `X.Y.Z+1` |
| `docs: document files api` | No release | `X.Y.Z` |
| `chore: remove commented code from file upload` | No release | `X.Y.Z` |
| `refactor: rename a variable (invisible change)` | No release | `X.Y.Z` |

### Step 6: Rebase

Expand All @@ -66,7 +92,9 @@ This will add your changes on top of what's already in upstream, minimizing merg

### Step 7: Run the tests

Make sure that all tests are passing before submitting a pull request.
Make sure that all tests are passing before submitting a pull request by running:

`dotnet test`

### Step 8: Send the pull request

Expand Down