feat: add BoxSign API support #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antusus
requested changes
Oct 29, 2021
| /// <summary> | ||
| /// Reminds signers to sign a document on day 3, 8, 13 and 18. Reminders are only sent to outstanding signers. | ||
| /// </summary> | ||
| [JsonProperty(PropertyName = "are_reminders_enabled")] |
There was a problem hiding this comment.
I like it more when we can see the name of the field and it is not obscured by variable with name field.
There was a problem hiding this comment.
This is usual approach in the .NET SDK. We expose field names as variables (customer can use it in some way). For *Create requests is not necessary. This is something we can discuss further, but for now we should stick to the usual approach in my opinion.
Move new enums to same nesting level as classes
antusus
previously approved these changes
Nov 2, 2021
arjankowski
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs here #761.