Box exceptions rework according to the reference architecture #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract getter for error code and error description Remove unecessary throw exception from folder manager test
mwwoda
changed the title
antusus
previously approved these changes
Sep 30, 2021
antusus
approved these changes
Sep 30, 2021
This is true for the input, but we also throw this exception after the API cal. According to our reference architecture, we should use these exceptions when encoding or decoding an http request. We could also distinguish between Coding and Validation errors, but I'm not sure if there are enough benefits to do this right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A distinction has been made between errors for coding errors (maybe we can think of a better name(?)), API errors and common errors based on reference architecture. This should make it easier to handle e.g. retries. Also got rid of unnecessary setters.
Also solves SDK-1528. The Error object should always be present in case of an API error (otherwise it's a problem in the API), but just in case, I added a default value for the code and message where necessary.