Add BoxConfigBuilder and make BoxConfig immutable #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hide setters in BoxConfig and make it immutable
PJSimon
approved these changes
Aug 6, 2021
| public virtual Uri BoxAccountApiHostUri { get; set; } = new Uri(Constants.BoxAccountApiHostUriString); | ||
| public virtual Uri BoxApiUri { get; set; } = new Uri(Constants.BoxApiUriString); | ||
| public virtual Uri BoxUploadApiUri { get; set; } = new Uri(Constants.BoxUploadApiUriString); | ||
| public Uri BoxApiHostUri { get; private set; } = new Uri(Constants.BoxApiHostUriString); |
There was a problem hiding this comment.
Why all the virtual methods in BoxConfig? Where were they being overridden? Why can the be made not virtual now?
There was a problem hiding this comment.
They were not overridden anywhere in our SDK. If we expose IBoxConfig it could be used instead so there is no value for having virtual properties there (also the class is now sealed so it could not be derived from). See also explanation in #401.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created BoxConfigBuilder to make it easier to create new BoxConfig (fluent builder, used in .NET Core to build configuration so .NET devs should be familiar with this).
At the same time BoxConfig was made immutable. I could also remove constructors from BoxConfig, but it would make it more 'breaking' that it is at the moment. To be discussed.