feat(tasks): new task card layout #893
Conversation
|
Verified that @alexkrolick has signed the CLA. Thanks for the pull request! |
package.json
Outdated
| @@ -167,8 +170,8 @@ | |||
| "cypress": "^3.1.5", | |||
| "deepmerge": "^2.1.1", | |||
| "draft-js": "^0.10.1", | |||
| "enzyme": "^3.6.0", | |||
| "enzyme-adapter-react-16": "^1.5.0", | |||
| "enzyme": "3.8.0", | |||
There was a problem hiding this comment.
Latest is 3.9.0 but there is a new bug that affected one of our tests: enzymejs/enzyme#2020
alexkrolick
force-pushed
the
feat/tasks/new-api
branch
2 times, most recently
from
2206d78
to
101d6f1
Compare
|
Can this PR be broken into multiple small ones
|
|
Will rebase after the sub-PRs |
alexkrolick
force-pushed
the
feat/tasks/new-api
branch
from
b2c8b11
to
44141c9
Compare
alexkrolick
force-pushed
the
feat/tasks/new-api
branch
from
44141c9
to
00952c0
Compare
src/elements/content-sidebar/activity-feed/activity-feed/ActiveState.js
Outdated
Show resolved
Hide resolved
src/elements/content-sidebar/activity-feed/activity-feed/__tests__/ActiveState-test.js
Outdated
Show resolved
Hide resolved
src/elements/content-sidebar/activity-feed/task-new/PendingAssignment.js
Outdated
Show resolved
Hide resolved
| taskType?: TaskType, | ||
| }; | ||
|
|
||
| const TaskActions = ({ onTaskApproval, onTaskReject, onTaskComplete, taskType }: Props): React.Node => ( |
There was a problem hiding this comment.
This looks like it may be a duplicate of the other TaskActions component.
There was a problem hiding this comment.
what other taskactions?
| } | ||
| }; | ||
|
|
||
| const StatusMessage = ({ status }: { status: TaskStatus }) => { |
There was a problem hiding this comment.
We usually try to stick to one component per file.
There was a problem hiding this comment.
There was a problem hiding this comment.
It seems like not exporting the components would make it difficult to test them in isolation. @priyajeet, thoughts?
alexkrolick
force-pushed
the
feat/tasks/new-api
branch
from
56bcc51
to
f96b953
Compare
alexkrolick
force-pushed
the
feat/tasks/new-api
branch
from
f96b953
to
44c4822
Compare
- this is feature-flagged under activityFeed.tasks.newApi - tasks are created and read from new service when enabled - the new API format is not compatible with the old one
- there are 538 warnings for this - do we still need --max-warnings=0 or are we happy with the error/warning ratio now?
alexkrolick
force-pushed
the
feat/tasks/new-api
branch
from
44c4822
to
20f4295
Compare
|
🎉 This PR is included in version 10.0.0-beta.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 10.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Changes are feature-flagged as new features are added for the new API
New
Old
