-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(content-sidebar): add new callback prop in box-ai-sidebar #3995
feat(content-sidebar): add new callback prop in box-ai-sidebar #3995
Conversation
@@ -186,6 +187,24 @@ describe('elements/content-sidebar/BoxAISidebar', () => { | |||
}); | |||
}); | |||
|
|||
test('should call setHasQuestions on load if questions is not empty', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we have a test that verifies that setHasQuestions is not called if the questions are not empty?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setHasQuestions should be called whether questions are empty or not
should be called with "true" when questions are not empty
should be called with "false" when questions are empty
will update test for these two different case
accf77d
to
f3dc97d
Compare
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
@Mergifyio requeue |
❌ Command disallowed due to command restrictions in the Mergify configuration.
|
Description
This change along, with EUA, Show header BoxAI purple button state in Preview when there’s an ongoing Q&A chat.
DEMO