Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content-sidebar): add new callback prop in box-ai-sidebar #3995

Merged

Conversation

fpan225
Copy link
Contributor

@fpan225 fpan225 commented Feb 28, 2025

Description

This change along, with EUA, Show header BoxAI purple button state in Preview when there’s an ongoing Q&A chat.

DEMO

Purple button

@fpan225 fpan225 requested a review from a team as a code owner February 28, 2025 05:36
@fpan225 fpan225 changed the title Content sidebar/new prop sethasquestions feat(content-sidebar): add new callback prop sethasquestions in boxaisidebar Feb 28, 2025
@fpan225 fpan225 changed the title feat(content-sidebar): add new callback prop sethasquestions in boxaisidebar feat(content-sidebar): add new callback prop in box-ai-sidebar Feb 28, 2025
@@ -186,6 +187,24 @@ describe('elements/content-sidebar/BoxAISidebar', () => {
});
});

test('should call setHasQuestions on load if questions is not empty', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we have a test that verifies that setHasQuestions is not called if the questions are not empty?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setHasQuestions should be called whether questions are empty or not
should be called with "true" when questions are not empty
should be called with "false" when questions are empty
will update test for these two different case

@fpan225 fpan225 force-pushed the content-sidebar/new-prop-sethasquestions branch from accf77d to f3dc97d Compare March 4, 2025 15:59
Copy link
Contributor

mergify bot commented Mar 4, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@fpan225
Copy link
Contributor Author

fpan225 commented Mar 5, 2025

@Mergifyio requeue

Copy link
Contributor

mergify bot commented Mar 5, 2025

requeue

❌ Command disallowed due to command restrictions in the Mergify configuration.

  • sender-permission >= write

@mergify mergify bot merged commit 1a7c8a8 into box:master Mar 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants