fix: remove selector from theming #3879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjiang-box
approved these changes
Jan 30, 2025
jpan-box
approved these changes
Jan 30, 2025
JChan106
reviewed
Jan 30, 2025
| @@ -11,15 +11,19 @@ const useCustomTheming = ({ selector, theme = {} }: ThemingProps) => { | |||
| .join(';'); | |||
|
|
|||
| useEffect(() => { | |||
| if (!styles) { | |||
| return undefined; | |||
There was a problem hiding this comment.
We shouldn't return anything here for useEffect. We would want to just end execution with return; right?
There was a problem hiding this comment.
yes! I wanted to do that but there's an eslint rule about consistent returns: https://eslint.org/docs/latest/rules/consistent-return#treatundefinedasunspecified
basically return; (implicit undefined) doesn't work but return undefined; (explicit) does work 🤷
JChan106
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's currently a bug where theming isn't applying to floating components like dropdown menus because the component is inserted at the body of the DOM, outside of the UI Element.
Removing the selector functionality to insert the CSS variables at the root fixes this but it means UI Elements will have to share themes. The alternative approach is to individually portal all usages of the floating components but that sounds awful.
Theming applied to dropdown menu:
